-
Notifications
You must be signed in to change notification settings - Fork 7
Prepare for next version of node/ocean.js #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexcos20
wants to merge
32
commits into
main
Choose a base branch
from
feature/next-node-4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1596062
use next version of ocean.js
alexcos20 8c76130
fix node/js versions
alexcos20 f461a86
Merge branch 'main' into feature/next-node-4
alexcos20 f4bd3d9
services
alexcos20 8461865
run tests on evert PR
alexcos20 0bbe0c1
fix bugs
alexcos20 61d2874
global ocean-cli
alexcos20 1523adb
Release v2.0.0-next.2
alexcos20 1f58c82
fix package url
alexcos20 e7c4e13
Release v2.0.0-next.3
alexcos20 b7b7754
fixes
alexcos20 7395609
Release v2.0.0-next.4
alexcos20 09f6ed1
update to support service restart
alexcos20 fb47e5c
Merge branch 'feature/services' into feature/cli_global
alexcos20 e5d9c30
Update .github/workflows/ci.yml
alexcos20 265e8fd
fixes
alexcos20 dca9a55
Merge branch 'feature/cli_global' of https://github.com/oceanprotocol…
alexcos20 e18575f
fix ci
alexcos20 59bbd58
allow user to setNode
alexcos20 d37b212
fix
alexcos20 e40a4cb
fix review
alexcos20 df66ae3
fix review
alexcos20 6091f8e
Merge pull request #166 from oceanprotocol/feature/set_node
alexcos20 0e8dc8c
Merge pull request #164 from oceanprotocol/feature/cli_global
alexcos20 d101611
Merge pull request #163 from oceanprotocol/feature/services
alexcos20 c7df4c4
use latest ocean.js
alexcos20 88d707e
fix tests
alexcos20 50fa5bb
add logs
alexcos20 55a83b4
fix
alexcos20 feb0a9d
fix
alexcos20 f839abf
fix nonce conflict
alexcos20 64c6444
fix stream logs
alexcos20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| name: Publish | ||
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - "v*" | ||
|
|
||
| permissions: | ||
| contents: read | ||
| id-token: write # required for npm provenance | ||
|
|
||
| jobs: | ||
| npm: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "22.5.1" | ||
| registry-url: "https://registry.npmjs.org/" | ||
|
|
||
| # Only publish a tag whose version matches package.json, so a stray or | ||
| # mistyped tag can never publish a mismatched release. | ||
| - name: Verify tag matches package.json version | ||
| run: | | ||
| TAG_VERSION="${GITHUB_REF_NAME#v}" | ||
| PKG_VERSION="$(node -p "require('./package.json').version")" | ||
| if [ "$TAG_VERSION" != "$PKG_VERSION" ]; then | ||
| echo "Tag $GITHUB_REF_NAME (version $TAG_VERSION) does not match package.json version $PKG_VERSION" | ||
| exit 1 | ||
| fi | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| # prepublishOnly (npm run build) runs automatically during npm publish. | ||
| # --access public is required for a scoped package; --provenance attests | ||
| # the build to the source commit (needs the package.json `repository` | ||
| # field to match this repo and the id-token permission above). | ||
| - name: Publish (next) | ||
| if: contains(github.ref, 'next') | ||
| run: npm publish --tag next --provenance --access public | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
|
|
||
| - name: Publish (latest) | ||
| if: ${{ !contains(github.ref, 'next') }} | ||
| run: npm publish --provenance --access public | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| ### Changelog | ||
|
|
||
| All notable changes to this project will be documented in this file. Dates are displayed in UTC. | ||
|
|
||
| Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | ||
|
|
||
| #### [v2.0.0-next.4](https://github.com/oceanprotocol/ocean-cli/compare/v2.0.0-next.3...v2.0.0-next.4) | ||
|
|
||
| - fixes [`b7b7754`](https://github.com/oceanprotocol/ocean-cli/commit/b7b7754fa881f857358c00f2c2ba8aa2b3ac68e7) | ||
|
|
||
| #### [v2.0.0-next.3](https://github.com/oceanprotocol/ocean-cli/compare/v2.0.0-next.2...v2.0.0-next.3) | ||
|
|
||
| > 24 July 2026 | ||
|
|
||
| - Release v2.0.0-next.3 [`e7c4e13`](https://github.com/oceanprotocol/ocean-cli/commit/e7c4e13fc8314233d52145e4db306048cc4d404e) | ||
| - fix package url [`1f58c82`](https://github.com/oceanprotocol/ocean-cli/commit/1f58c82aba84a9e7b0b49e3e328024c16441ffc8) | ||
|
|
||
| #### [v2.0.0-next.2](https://github.com/oceanprotocol/ocean-cli/compare/v1.0.0...v2.0.0-next.2) | ||
|
|
||
| > 24 July 2026 | ||
|
|
||
| - fix interactive menu [`#162`](https://github.com/oceanprotocol/ocean-cli/pull/162) | ||
| - ddoJs for v5 [`#131`](https://github.com/oceanprotocol/ocean-cli/pull/131) | ||
| - Feature/add claude [`#158`](https://github.com/oceanprotocol/ocean-cli/pull/158) | ||
| - codeowner [`#157`](https://github.com/oceanprotocol/ocean-cli/pull/157) | ||
| - Feature/allow full compute asset [`#156`](https://github.com/oceanprotocol/ocean-cli/pull/156) | ||
| - Change order initial users param [`#155`](https://github.com/oceanprotocol/ocean-cli/pull/155) | ||
| - Bucket methods [`#154`](https://github.com/oceanprotocol/ocean-cli/pull/154) | ||
| - bump ocean.js + ddo.js [`#152`](https://github.com/oceanprotocol/ocean-cli/pull/152) | ||
| - ocean.js p2p [`#151`](https://github.com/oceanprotocol/ocean-cli/pull/151) | ||
| - feat(#148): expose external storage c2d [`#150`](https://github.com/oceanprotocol/ocean-cli/pull/150) | ||
| - use latest ocean.js [`#147`](https://github.com/oceanprotocol/ocean-cli/pull/147) | ||
| - chore: add example metadata [`#132`](https://github.com/oceanprotocol/ocean-cli/pull/132) | ||
| - chore: buy v5 [`bc2b222`](https://github.com/oceanprotocol/ocean-cli/commit/bc2b2227c08620a63e171ab9e8d1660a3190bd4a) | ||
| - fix: removed file downaloded [`c99c066`](https://github.com/oceanprotocol/ocean-cli/commit/c99c06639dd6ad3a4c2f93ba01f5163bc77ec24f) | ||
| - fix: lint [`a91ee21`](https://github.com/oceanprotocol/ocean-cli/commit/a91ee21b6c59b44c3b93cee84286abf881bac1bc) | ||
|
|
||
| #### v1.0.0 | ||
|
|
||
| > 27 February 2026 | ||
|
|
||
| - use oceanlib v6 [`#146`](https://github.com/oceanprotocol/ocean-cli/pull/146) | ||
| - feat(logs): add downloadNodeLogs cli command [`#144`](https://github.com/oceanprotocol/ocean-cli/pull/144) | ||
| - fix: update get logs test after getLogsHandler p2p update [`#143`](https://github.com/oceanprotocol/ocean-cli/pull/143) | ||
| - Feature/bump_oceanlib_to_510 [`#141`](https://github.com/oceanprotocol/ocean-cli/pull/141) | ||
| - add copilot instructions [`#140`](https://github.com/oceanprotocol/ocean-cli/pull/140) | ||
| - add n8n flow [`#139`](https://github.com/oceanprotocol/ocean-cli/pull/139) | ||
| - Node version and module type [`#137`](https://github.com/oceanprotocol/ocean-cli/pull/137) | ||
| - bump ocean libs [`#136`](https://github.com/oceanprotocol/ocean-cli/pull/136) | ||
| - Updated docs [`#135`](https://github.com/oceanprotocol/ocean-cli/pull/135) | ||
| - Access list methods [`#133`](https://github.com/oceanprotocol/ocean-cli/pull/133) | ||
| - update codeowners [`#134`](https://github.com/oceanprotocol/ocean-cli/pull/134) | ||
| - Update libs and ethers [`#127`](https://github.com/oceanprotocol/ocean-cli/pull/127) | ||
| - Fix publisher trusted algorithms structure for compute dataset. [`#125`](https://github.com/oceanprotocol/ocean-cli/pull/125) | ||
| - Feature/paid auth extra commands [`#124`](https://github.com/oceanprotocol/ocean-cli/pull/124) | ||
| - Fix parsing compute envs for ocean-node system tests. [`#121`](https://github.com/oceanprotocol/ocean-cli/pull/121) | ||
| - Feature/paid-compute in cli [`#115`](https://github.com/oceanprotocol/ocean-cli/pull/115) | ||
| - bump ocean.js [`#120`](https://github.com/oceanprotocol/ocean-cli/pull/120) | ||
| - Update ocean.js [`#119`](https://github.com/oceanprotocol/ocean-cli/pull/119) | ||
| - Remove legacy env vars like AQUARIUS and PROVIDER urls [`#111`](https://github.com/oceanprotocol/ocean-cli/pull/111) | ||
| - Update CODEOWNERS [`#112`](https://github.com/oceanprotocol/ocean-cli/pull/112) | ||
| - avoid cli to exit, loop commands [`#99`](https://github.com/oceanprotocol/ocean-cli/pull/99) | ||
| - add authorized publishers, update DDO validate call [`#90`](https://github.com/oceanprotocol/ocean-cli/pull/90) | ||
| - Fix start free compute - Fix logic for METADATA_CACHE_URI [`#109`](https://github.com/oceanprotocol/ocean-cli/pull/109) | ||
| - Release SDK 4.0 C2D V2 [`#89`](https://github.com/oceanprotocol/ocean-cli/pull/89) | ||
| - Issue ddo id with lib [`#101`](https://github.com/oceanprotocol/ocean-cli/pull/101) | ||
| - fix node branch [`#103`](https://github.com/oceanprotocol/ocean-cli/pull/103) | ||
| - use latest ocean.js [`#100`](https://github.com/oceanprotocol/ocean-cli/pull/100) | ||
| - Fix consume flow tests for new DDO structure [`#87`](https://github.com/oceanprotocol/ocean-cli/pull/87) | ||
| - Fix p2p test. [`#98`](https://github.com/oceanprotocol/ocean-cli/pull/98) | ||
| - Issue 96 consumeflow file [`#97`](https://github.com/oceanprotocol/ocean-cli/pull/97) | ||
| - updating cli to use command cli library [`#88`](https://github.com/oceanprotocol/ocean-cli/pull/88) | ||
| - Use createAsset function from SDK. [`#73`](https://github.com/oceanprotocol/ocean-cli/pull/73) | ||
| - pass config argument when we have it [`#84`](https://github.com/oceanprotocol/ocean-cli/pull/84) | ||
| - Fixing bug where feeToken is always Ocean [`#79`](https://github.com/oceanprotocol/ocean-cli/pull/79) | ||
| - refactor fn call waitForAqua to waitForIndexer [`#86`](https://github.com/oceanprotocol/ocean-cli/pull/86) | ||
| - increase MAX_REQ_PER_MINUTE for system tests [`#81`](https://github.com/oceanprotocol/ocean-cli/pull/81) | ||
| - Delete node:16 docker image from workflow. [`#76`](https://github.com/oceanprotocol/ocean-cli/pull/76) | ||
| - Setting up cli interactive flow [`#71`](https://github.com/oceanprotocol/ocean-cli/pull/71) | ||
| - add check for computeoutput, ips [`#65`](https://github.com/oceanprotocol/ocean-cli/pull/65) | ||
| - Adding tests for downloading assets [`#68`](https://github.com/oceanprotocol/ocean-cli/pull/68) | ||
| - Issue 62 - add default filename on downloadFile [`#63`](https://github.com/oceanprotocol/ocean-cli/pull/63) | ||
| - Updating access [`#67`](https://github.com/oceanprotocol/ocean-cli/pull/67) | ||
| - Fix compute assets samples [`#61`](https://github.com/oceanprotocol/ocean-cli/pull/61) | ||
| - add missing algo meta to request to start compute [`#59`](https://github.com/oceanprotocol/ocean-cli/pull/59) | ||
| - Issue 54 agreementid stop [`#56`](https://github.com/oceanprotocol/ocean-cli/pull/56) | ||
| - computeStatus - add support for `agreementId` [`#53`](https://github.com/oceanprotocol/ocean-cli/pull/53) | ||
| - Bump ocean.js lib [`#55`](https://github.com/oceanprotocol/ocean-cli/pull/55) | ||
| - Test flow with Ocean Node [`#49`](https://github.com/oceanprotocol/ocean-cli/pull/49) | ||
| - Bump ocean lib [`#51`](https://github.com/oceanprotocol/ocean-cli/pull/51) | ||
| - Compute jobs with multiple datasets & selectable compute env [`#34`](https://github.com/oceanprotocol/ocean-cli/pull/34) | ||
| - Fix/provider url override if env var is set [`#47`](https://github.com/oceanprotocol/ocean-cli/pull/47) | ||
| - fix for loop [`#48`](https://github.com/oceanprotocol/ocean-cli/pull/48) | ||
| - Fix validation order [`#45`](https://github.com/oceanprotocol/ocean-cli/pull/45) | ||
| - set proper flags for metadata [`#41`](https://github.com/oceanprotocol/ocean-cli/pull/41) | ||
| - fix editAsset command [`#44`](https://github.com/oceanprotocol/ocean-cli/pull/44) | ||
| - bump ocean.js [`#40`](https://github.com/oceanprotocol/ocean-cli/pull/40) | ||
| - Bump ocean lib and remove logs [`#39`](https://github.com/oceanprotocol/ocean-cli/pull/39) | ||
| - Fix/ unencrypt publish [`#38`](https://github.com/oceanprotocol/ocean-cli/pull/38) | ||
| - Publish DDO without encrypt option [`#35`](https://github.com/oceanprotocol/ocean-cli/pull/35) | ||
| - Fix readme private key [`#31`](https://github.com/oceanprotocol/ocean-cli/pull/31) | ||
| - Update README.md [`#30`](https://github.com/oceanprotocol/ocean-cli/pull/30) | ||
| - Fix/ Mnemonic - Private key & Provider - Aquarius usage [`#29`](https://github.com/oceanprotocol/ocean-cli/pull/29) | ||
| - Readme, package.json updates & small fixes [`#21`](https://github.com/oceanprotocol/ocean-cli/pull/21) | ||
| - Add download c2d Job Result [`#17`](https://github.com/oceanprotocol/ocean-cli/pull/17) | ||
| - Build-in support for Barge on macOS [`#18`](https://github.com/oceanprotocol/ocean-cli/pull/18) | ||
| - bump ocean.js lib [`#20`](https://github.com/oceanprotocol/ocean-cli/pull/20) | ||
| - Bump ocean.js lib 3.1.1 [`#16`](https://github.com/oceanprotocol/ocean-cli/pull/16) | ||
| - Feature/ Support oceanjs v3 [`#6`](https://github.com/oceanprotocol/ocean-cli/pull/6) | ||
| - Update URL [`#5`](https://github.com/oceanprotocol/ocean-cli/pull/5) | ||
| - remove old code [`719a969`](https://github.com/oceanprotocol/ocean-cli/commit/719a9694749b9f77f45a8bc66ed862f36cfc90c7) | ||
| - refactor vars [`3951f5f`](https://github.com/oceanprotocol/ocean-cli/commit/3951f5fa0826ae0d05bd1d25726d1e053fab28c1) | ||
| - minor fix, allow empty datasets [`0e0281c`](https://github.com/oceanprotocol/ocean-cli/commit/0e0281ce790045bc8b2a87b2b65e9de27646b245) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: oceanprotocol/ocean-cli
Length of output: 5931
🌐 Web query:
official actions/checkout README persist-credentials default true .git/config GITHUB_TOKEN💡 Result:
In the official actions/checkout GitHub Action, the persist-credentials input defaults to true [1][2][3]. When persist-credentials is set to true (the default), the action configures the provided GITHUB_TOKEN (or SSH key) to allow subsequent Git commands to run authenticated [1][4][5]. Regarding how these credentials are stored: - Historically, the token was stored directly in the local.git/config file [3][5][6]. - In more recent versions, specifically following improvements to credential security, the action stores these credentials in a separate file within $RUNNER_TEMP instead of directly modifying the.git/config file [3][6]. It uses Git's includeIf mechanism to conditionally apply these credentials [6]. The token is removed during the post-job cleanup phase of the action [1][5]. You can set persist-credentials: false in your workflow step if you wish to opt-out of this behavior [1][4][5].
Citations:
🏁 Script executed:
Repository: oceanprotocol/ocean-cli
Length of output: 271
🏁 Script executed:
Repository: oceanprotocol/ocean-cli
Length of output: 10036
🏁 Script executed:
Repository: oceanprotocol/ocean-cli
Length of output: 10544
Disable persisted checkout credentials.
A dependency lifecycle script launched by
npm cican read and exfiltrate the persistedGITHUB_TOKEN. Setpersist-credentials: false, as in thepack_smokejob.🧰 Tools
🪛 zizmor (1.29.0)
[warning] 17-18: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Source: Linters/SAST tools