frontend: API call obs_frontend_add_transition()#13633
Open
xurei wants to merge 2 commits into
Open
Conversation
d86d2b7 to
ad96193
Compare
This allows to add a transition without showing the properties UI
ad96193 to
860bc07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR on the OBS project, I hope I'll do it as expected :-)
Description
This PR adds the
obs_frontend_add_transition()frontend API call.This function allows to add global transitions in the collection without showing the popups.
This change required two modifications :
OBSBasic::AddTransition()with two new arguments :const char *transitionName = nullptr, bool showProperties = true. The default values ensures retro-compatibility.obs_source_t *obs_frontend_add_transition()to the frontend API, with the related documentationMotivation and Context
I needed this to make a backup system for transitions in my plugin.
I didn't find any reason why it wasn't there, so I assumed it was forgotten.
However, there might be a reason why it wasn't implemented in the first place.
How Has This Been Tested?
I have tested this on Linux with success, not on Windows or MacOS.
Given the changes made, I don't believe much more testing is required.
Types of changes
Checklist: