Avoid persisting Dragon checkout credentials - #3738
Draft
cmungall wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghcredential helperGH_TOKENto the Claude step instead of writing it toGITHUB_ENVWhy
The checkout credential was previously available through Git configuration and could be captured when an agent inspected
.git/config. This avoids that accidental exposure path while preserving intelligentghusage and authenticatedgit push.Security boundary
The agent still receives
PAT_FOR_PRasGH_TOKENand as the Claude actiongithub_tokeninput, so it retains the requested GitHub capabilities. This change prevents persistence-based accidental disclosure; it does not sandbox an agent with arbitrary shell access.Validation
yq eval '.' .github/workflows/ai-agent.ymlyamllint -d relaxed .github/workflows/ai-agent.yml(existing line-length warnings only)actionlint .github/workflows/ai-agent.ymlgit diff --check