Skip to content

fix(hr): correct document-expiry date formulas — CEL has no Timestamp+int #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 19, 2026
Merged

fix(hr): correct document-expiry date formulas — CEL has no Timestamp+int #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/hr/src/objects/hr_document.object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export const EmployeeDocument = ObjectSchema.create({
}),
is_expiring_soon: Field.formula({
label: 'Expiring Soon?',
expression: F`record.expires_at != null && record.expires_at >= today() && record.expires_at <= (today() + 30)`,
// `daysFromNow(30)`, not `today() + 30`: the CEL formula engine has no
// `Timestamp + int` operator, so `today() + 30` evaluates to null and the
// whole comparison silently fails. Day offsets go through the builtin.
expression: F`record.expires_at != null && record.expires_at >= today() && record.expires_at <= daysFromNow(30)`,
}),
is_expired: Field.formula({
label: 'Expired?',
Expand All @@ -57,7 +60,9 @@ export const EmployeeDocument = ObjectSchema.create({
expiry_status: Field.formula({
label: 'Expiry Status',
description: 'Single severity band for sorting/colour-coding the document list.',
expression: F`record.expires_at == null ? "none" : (record.expires_at < today() ? "expired" : (record.expires_at <= (today() + 30) ? "expiring_30d" : (record.expires_at <= (today() + 60) ? "expiring_60d" : "valid")))`,
// `daysFromNow(N)`, not `today() + N`: CEL has no `Timestamp + int` operator
// (see is_expiring_soon above), so the offset bands must use the builtin.
expression: F`record.expires_at == null ? "none" : (record.expires_at < today() ? "expired" : (record.expires_at <= daysFromNow(30) ? "expiring_30d" : (record.expires_at <= daysFromNow(60) ? "expiring_60d" : "valid")))`,
}),
notes: Field.markdown({ label: 'Notes' }),
},
Expand Down
Loading