docs(plugin-form): drop the doubled /** opener on the foldFormButtons comment - #4733
Merged
Merged
Conversation
…ns comment The doc comment above `foldFormButtons` in `ObjectForm.tsx` opened with two `/**` lines in a row, so the stray second opener was rendered as the first line of the JSDoc body. Removed the redundant opener line. Comment-only: `foldFormButtons` is module-private, so it reaches no published type declaration, and comments are stripped from the emitted JavaScript — the built output is unchanged. The changeset declares no release accordingly. Refs objectui#4661 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnQd8iMMUwXQEV1crFmQiQ
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Collaborator
Author
|
PM review — ACCEPT (reviewer of record, session Independently verified against GitHub, not the report:
Noted with approval: the dev surfaced the standing-contract vs AGENTS.md conflict on test invocation (the Gates at Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4661
Deletes the one redundant
/**opener line abovefoldFormButtonsinpackages/plugin-form/src/ObjectForm.tsx. The doc comment opened with two/**lines in a row, so the stray second opener was rendered as the first line of the JSDoc body.Nothing was broken and nothing rendered wrong — the card said as much when it filed this as observation-class. The only cost was to a reader meeting a malformed-looking opener and stopping to work out whether a bad merge had eaten something.
Scope
One line deleted, nothing else in the file touched:
Anchored by the
foldFormButtonsdeclaration rather than by line number, as both the card and the dispatch note asked. On this branch's merge-base (baa89a1ea) the doubled opener sat at lines 82-83 with the declaration at line 96 — the card recorded line 67 and the dispatch note 82-83, the drift being exactly the churn they predicted.Repo-wide sweep: one instance total, zero remaining
Ran the requested cheap repo-wide grep for consecutive
/**opener lines. This was the only instance in the repository. The post-fix sweep over every tracked file returns zero hits, so there is no follow-up finding issue to file — the sweep and the one-file fix happen to coincide here.The pattern was self-checked before its emptiness was trusted, since an empty grep result is otherwise indistinguishable from a silently broken pattern. Run against the pre-fix
origin/mainblob, the same pattern does report the pair:Release impact: none, and declared
node scripts/check-changeset-presence.mjsrequires a changeset for any edit under a released package'ssrc/, comment-only or not — it failed this branch until one was added, and its word is final. Complied with the empty-frontmatter form that AGENTS.md defines as the first-class "declares no release" answer, because that is what is true here:foldFormButtonsis module-private so it reaches no published type declaration, and comments are stripped from the emitted JavaScript, leaving the built output unchanged.objectui has no
skip-changesetmechanism, and none was used.Gates — all run at head
00825b5a5, after the final commitpnpm exec vitest run packages/plugin-form/pnpm exec turbo run type-check --filter=@object-ui/plugin-formpnpm exec turbo run lint --filter=@object-ui/plugin-formno-explicit-anywarnings, untouched by this diff)node scripts/check-changeset-presence.mjsnode scripts/check-changeset-no-major.mjsnode scripts/check-control-bytes.mjsTests were invoked in the repo-root path-filter form AGENTS.md mandates, not
pnpm --filter @object-ui/plugin-form test— the latter is the documented cwd trap that silently runs another package's suite and reports green.Provenance
Recorded while renaming
ObjectFormPropsfor #4650 (PR #4660), and deliberately not swept in there. Neither of those is addressed by this PR.Generated by Claude Code