chore(components): remove unread, unpublished component.yml metadata files - #4732
Conversation
…files packages/components/metadata/ held seven *.component.yml files (ObjectGrid, ObjectForm, Page, Chart, Menu, GridLayout, FilterBuilder) describing each component's props/events/features. Nothing reads them (no source file, script, or workflow references component.yml or components/metadata), they are not published (packages/components/package.json's files allowlist is ["dist", "README.md", "CHANGELOG.md", "LICENSE"]), and no gate compares them against the zod schemas or renderers. ObjectGrid.component.yml's features block also carried a false claim: virtual_scroll: true, while packages/plugin-grid (which implements object-grid) has zero references to virtualScroll/virtual_scroll — the claim was false before objectstack#7176 retired the upstream list.virtualScroll key, and the retirement only removed any prospect of it becoming true. Delete the directory rather than wire up a reader: no consumer is measured or planned (a designer palette / docs generator / MCP capability manifest would be new product surface, not a fix for drifted docs), and startup-focus reading favours removal absent a real pull. Fixes #4659 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnQd8iMMUwXQEV1crFmQiQ
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
|
PM review — ACCEPT (reviewer of record, session Deletion-class PR, so per the dispatch commitment I re-tested all three reference faces independently on
Scope check: Changeset: none owed and none added — Gates at This closes the no-consumer retirement family's last open member (#4152 → #4241 → #4659), on the delegated adjudication recorded on the card (delete, don't build a reader). Generated by Claude Code |
Fixes #4659
What
Deletes
packages/components/metadata/(seven*.component.ymlfiles:ObjectGrid,ObjectForm,Page,Chart,Menu,GridLayout,FilterBuilder) describing each component's props/events/features.Why (adjudicated: delete, not "give them a reader")
This is a weaker instance of the established no-consumer retirement family:
scripts/, or workflow referencescomponent.ymlorcomponents/metadataanywhere in the repo (verified withthe card's own pointers plus an expanded sweep over
apps/*/src,examples/,content/, README files, and tsconfig/eslint config globs).packages/components/package.json'sfilesallowlist is["dist", "README.md", "CHANGELOG.md", "LICENSE"]— the directory neverleaves the repo.
renderer, which is the check that would give the files a job.
Urgency limb — one of the files was actively lying.
ObjectGrid.component.yml'sfeatures:block declared:packages/plugin-grid(which implementsobject-grid) has zeroreferences to
virtualScrollorvirtual_scroll— confirmed withgrep -rn "virtualScroll\|virtual_scroll" packages/plugin-grid/. The claimwas false before objectstack#7176 retired the upstream
list.virtualScrollkey; the retirement only removed any prospect of it becoming true. An agent
or contributor reading this file learns something false about the grid.
Per the delegated adjudication on the issue: giving the files a reader
(designer palette / docs generator / MCP capability manifest) is new product
surface with no measured consumer, and startup-focus reading favours removal
absent a real pull. Not building a reader for these files in this PR.
Verification
grep -rn "component\.yml\|components/metadata" scripts/ .github/workflows/ packages/*/src apps/*/src examples/→ no hits.A broader repo-wide sweep (
content/, README files, tsconfig/eslintconfigs) also found no functional references — the only other hit anywhere
in the tree is a prose mention of
ObjectGrid.component.ymlinside analready-existing, unreleased
.changeset/lucky-pumas-repeat.md(from theobjectstack#7176 unwind, PR refactor: unwind the retired striped/bordered/virtualScroll list-view surface (objectstack#7176) #4657), documenting a past edit — not a
functional dependency.
packages/components/package.jsonfilesallowlist above.
virtual_scrollclaim: confirmed zero hits inplugin-grid/.Tests
At
dfceccd96(final commit, matches pushed HEAD):pnpm --filter '@object-ui/components^...' build— dependency closurebuilds clean.
pnpm exec vitest run --maxWorkers=2 packages/components/(root-relativeinvocation per AGENTS.md) —
Test Files 130 passed (130),Tests 1116 passed (1116).pnpm --filter @object-ui/components type-check— clean (tsc --noEmit && tsc -p tsconfig.test.json).pnpm --filter @object-ui/components lint—0 errors, 920 pre-existingwarnings in
src/ui/**(the Shadcn no-touch zone), none related to thischange.
node scripts/check-control-bytes.mjs— OK.node scripts/check-doc-links.mjs— links valid across 13 scan roots.node scripts/check-changeset-presence.mjs—0 of them under the src/ of a package the release covers ... No source of a released package changed in this range, so no changeset is owed.(metadata/ is not undersrc/.)Changeset
Not added —
check-changeset-presence.mjsjudges none owed (see gate outputabove); this only touches
packages/components/metadata/, notsrc/.Generated by Claude Code