Skip to content

fix(i18n): close the last three zh-branch gaps (#2871, part 3) - #2898

Merged
os-zhuang merged 1 commit into
mainfrom
claude/custom-system-page-i18n-6ni3f8
Jul 28, 2026
Merged

fix(i18n): close the last three zh-branch gaps (#2871, part 3)#2898
os-zhuang merged 1 commit into
mainfrom
claude/custom-system-page-i18n-6ni3f8

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Part 3 of #2871, after #2887 and #2893. These are the three items the classification marked as real but not a migrate-the-copy fix — each needed a different remedy, which is why they were held back from the earlier parts.

1. LoadingScreen — ten languages collapsed to two

The boot splash already selected real locale packs (not inline copy), so it wasn't in the pick() cluster. But it chose via lang.startsWith('zh') ? zh : en, so a ja/ko/de user watched the entire startup in English.

Now indexes builtInLocales by two-letter prefix — but with a per-field fallback to en, which is the part that matters:

return {
  ...enLocale.console,
  ...pack,
  loadingSteps: { ...enLocale.console.loadingSteps, ...pack.loadingSteps },};

console.* is one of the namespaces trailing in the non-zh packs (#2872 part a), so a whole-object swap would have rendered undefined on the splash rather than English. I checked every key this component reads across all ten packs before writing it, and console.loadingHint was in fact missing from all eight — added here, because a blank line under the progress list is worse than an English one.

The useObjectTranslation ban stays: this renders before i18next initialises, and on a server-down boot i18n can't load at all.

2. containers.tsx — two language sources that could disagree

The tab-label call sites resolved language from useObjectTranslation(), then passed the string to translateLabel, which called detectLocale() and read document.documentElement.lang itself. Those two update independently, so an in-app language switch could leave a tab label and the chrome around it in different languages until the next reload.

language is now threaded in, and detectLocale is deleted so nothing in this file reaches for the DOM again. KNOWN_LABEL_DICT and the '与' CJK separator stay — per the classification, normalising author-supplied schema data is legitimate and is not UI copy.

3. field-types.ts — a two-language data catalog

FieldTypeMeta carried a labelZh column beside label, which capped the field-type picker at English-or-Chinese by construction. The 46 type names and 9 category names move into the Studio catalog as engine.fieldType.<id> / engine.fieldCategory.<cat>.

I generated those 110 entries from the existing values rather than retyping them, so no wording drifts in this change.

This is what removes isZh from both ObjectFieldInspector and ObjectFormCanvas — the two files the classification listed as "keep the component, fix the catalog". labelZh, CATEGORY_LABEL_ZH, and the unknown-type fallback's Chinese '未知' are all gone with it.

Caught while in there: the picker's search filter matched id, the English label, and labelZh — so typing a Japanese or German field-type name matched nothing. It now matches the label as the user actually sees it.

Verification

Full suite 7730 passed, 1 skipped, 0 failed. ESLint errors identical to baseline (25, all pre-existing). turbo type-check 31/31 on the changed packages.

One thing worth flagging from the type-check: my first version annotated getStartupStrings(): typeof enLocale.console, which failed because en's literal-typed consts don't accept another pack's widened strings. Dropping the annotation and letting TS infer is correct — the consumers only read strings.

Where #2871 stands after this

All 7 genuine bugs are fixed across parts 1–3. What remains under that issue is only the deliberate keeps: conversationLanguage (detects the chat's language for the agent), the Studio catalog itself (1375 keys, ~1255 call sites — a multi-week refactor with no user-visible gain), and KNOWN_LABEL_DICT. I'd suggest closing #2871 once this lands.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TubWYdWquVkS9dj733sDmC


Generated by Claude Code

The three items the classification marked as real but not a migrate-the-copy
fix. Each needed a different remedy.

LoadingScreen collapsed ten languages into two. It already selected real locale
packs rather than inline copy, but via `startsWith('zh') ? zh : en`, so a
ja/ko/de user watched the entire boot in English. Now indexes builtInLocales by
two-letter prefix, with a PER-FIELD fallback to `en` — `console.*` is one of the
namespaces trailing in the non-zh packs (#2872 part a), so a whole-object swap
would have rendered `undefined` on the splash instead of English.
`console.loadingHint` was in fact missing from all eight; added, because a blank
line under the progress list is worse than an English one.

containers.tsx had two language sources that could disagree: the call sites
resolved `language` from useObjectTranslation, then translateLabel called
detectLocale() and read document.documentElement.lang itself. Those update
independently, so an in-app language switch could leave a tab label and its
chrome in different languages until reload. `language` is threaded in and
detectLocale is deleted so nothing reaches for the DOM again.

field-types.ts carried a `labelZh` column beside `label`, capping the field-type
picker at two languages by construction. The 46 type names and 9 category names
move to the Studio catalog as `engine.fieldType.<id>` /
`engine.fieldCategory.<cat>`, generated from the existing values so no wording
changes. This removes `isZh` from BOTH ObjectFieldInspector and
ObjectFormCanvas — the two files classified as "keep the component, fix the
catalog".

Also caught while there: the picker's search filter matched id, the English
label, and `labelZh`, so searching in Japanese or German matched nothing. It now
matches the label as the user actually sees it.

Full suite 7730 passed. ESLint errors identical to baseline (25, all
pre-existing). turbo type-check 31/31 for the changed packages.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TubWYdWquVkS9dj733sDmC
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 28, 2026 4:01am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-BDbdB_xJ.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.17KB 0.96KB
auth (org-roles.js) 5.50KB 2.36KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 449.62KB 97.73KB
core (index.js) 2.12KB 0.77KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 127.78KB 32.15KB
fields (index.js) 218.37KB 53.54KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 179.50KB 42.71KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 214.86KB 52.39KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.47KB 25.10KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 178.13KB 46.73KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.64KB 23.33KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.07KB 9.81KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.68KB 20.85KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.86KB 0.91KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 28, 2026 04:05
@os-zhuang
os-zhuang merged commit dc334da into main Jul 28, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/custom-system-page-i18n-6ni3f8 branch July 28, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants