fix(detail): inline-edit enrichment passes min/max/step; live e2e for the #2572 polish set by os-zhuang · Pull Request #2615 · objectstack-ai/objectui

os-zhuang · 2026-07-16T14:35:12Z

Live-dogfood follow-up to #2572 / PR #2604, found by driving the merged polish on the real showcase stack (console dev :5191 + framework/examples/app-showcase).

Fix: numeric constraints were dropped by the field enrichment

DetailSection and HeaderHighlight enrich the field they hand InlineFieldInput by copying an explicit whitelist of objectSchema keys (type, options, currency, precision, scale, format, reference…). min/max/step were not in that list — so although #2604 taught NumberField/CurrencyField to surface them, the showcase Project.budget (currency, min: 0) still rendered its number input with no range constraints, because the metadata never reached the widget. Both enrichments now pass min/max/step through (unit tests added; the DetailSection one pins min/max/step on the rendered spinbutton).

New: live e2e spec for the whole #2572 polish set

e2e/live/inline-edit-polish-2572.spec.ts drives all five items end-to-end against the real stack and is green:

expanded-lookup passthrough — the Account chip shows "Northwind" with zero hydration findOne fetches;
approval-lock preflight — saving budget 150k→160k fires showcase_budget_approval (verified pending via the approvals API), and on reload every pencil/double-click affordance is gone and double-click no longer opens a session (note: this backend does not materialize approval_status on the record, so the lock engages via the pending-request branch of approvalLocked — with the field-only signal it would never lock);
currency edits in a real input[type=number][min=0][step=0.01];
header Edit CTA disabled while the session is live;
Esc cancels / Ctrl+Enter commits ONE atomic PATCH carrying only the edited key.

The run also flushed out a framework bug: the default CORS allow-list omitted If-Match, so every split-origin inline-edit save failed preflight with "Failed to fetch" — fixed separately in framework PR objectstack-ai/objectstack#3067 (the spec was verified green against that fixed stack).

Known cosmetic gap (pre-existing, not addressed here): DetailView's "Locked for approval" band keys off record.approval_status only, so on backends that track the lock purely via approval requests the band never shows even though editing is correctly locked.

Verification

plugin-detail suites green locally (DetailSection.inlineEdit + HeaderHighlight.editable: 10/10).
Live spec green end-to-end (18.6s) against showcase backend :4022 (with the framework CORS fix) + console dev :5191.
Live specs don't run in CI (they need a live backend), so this adds no CI cost.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JQjNZDdqmz2QHGQndpjZrR

Generated by Claude Code

…ive e2e (#2572) Live dogfood follow-up to the #2572 polish (PR #2604): DetailSection and HeaderHighlight enrich the field they hand InlineFieldInput from an explicit whitelist of objectSchema keys, and that list dropped the numeric range/step constraints — so a currency field declaring min: 0 rendered its number input with no min/max/step. Both enrichments now pass min/max/step through. Also adds e2e/live/inline-edit-polish-2572.spec.ts, a live spec driving the whole #2572 polish set against the real showcase stack (expanded-lookup passthrough with zero hydration fetches, currency min/step, header Edit CTA disable, Esc/Ctrl+Enter, and the approval-lock preflight via the showcase_budget_approval flow). Verified green end-to-end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JQjNZDdqmz2QHGQndpjZrR

vercel · 2026-07-16T14:35:18Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 16, 2026 2:35pm

github-actions · 2026-07-16T14:38:57Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.7 KB	350 KB
Entry file	`index-D5o8B7Oe.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.17KB	2.95KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.12KB	5.00KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	30.17KB	7.28KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	448.19KB	97.29KB
core (index.js)	1.82KB	0.62KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	115.42KB	28.53KB
fields (index.js)	208.25KB	50.87KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.87KB	1.28KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	176.76KB	42.28KB
plugin-dashboard (index.js)	117.25KB	29.14KB
plugin-designer (index.js)	213.89KB	43.03KB
plugin-detail (index.js)	212.42KB	51.68KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.96KB	25.43KB
plugin-gantt (index.js)	149.18KB	37.17KB
plugin-grid (index.js)	172.00KB	45.43KB
plugin-kanban (index.js)	47.23KB	12.88KB
plugin-list (index.js)	97.69KB	23.10KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.63KB	9.92KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.72KB	20.86KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.67KB	0.75KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added plugin tests labels Jul 16, 2026

os-zhuang marked this pull request as ready for review July 16, 2026 14:53

os-zhuang merged commit bb22788 into main Jul 16, 2026
10 checks passed

os-zhuang deleted the claude/record-inline-edit-polish-ns7mes branch July 16, 2026 14:53

os-zhuang mentioned this pull request Jul 16, 2026

"Locked for approval" band never shows on backends that track the lock via approval requests only (no approval_status field) #2618

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(detail): inline-edit enrichment passes min/max/step; live e2e for the #2572 polish set#2615

fix(detail): inline-edit enrichment passes min/max/step; live e2e for the #2572 polish set#2615
os-zhuang merged 1 commit into
mainfrom
claude/record-inline-edit-polish-ns7mes

os-zhuang commented Jul 16, 2026

Uh oh!

vercel Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 16, 2026

Fix: numeric constraints were dropped by the field enrichment

New: live e2e spec for the whole #2572 polish set

Verification

Uh oh!

vercel Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants