Skip to content

B3: cascading-option guardrail, role-gated demo, ADR-0058 + browser e2e (#1583)#2547

Merged
os-zhuang merged 1 commit into
mainfrom
claude/dynamic-field-options-cel-ywydwm
Jul 16, 2026
Merged

B3: cascading-option guardrail, role-gated demo, ADR-0058 + browser e2e (#1583)#2547
os-zhuang merged 1 commit into
mainfrom
claude/dynamic-field-options-cel-ywydwm

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

What & why

Completes the objectui side of B3 — dynamic field options / cascading selects (#1583). The client feature itself (per-option visibleWhen + dependsOn) shipped earlier in #2284 / #2215 (v12.0.0); this PR fills the remaining objectui checklist from the rewritten #1583: a build-time guardrail, a role-gated demo, the ADR, and a real-browser e2e.

Changes

  • @object-ui/corelintOptionPredicates() (packages/core/src/evaluator/optionLint.ts): a static, conservative validator for per-option visibleWhen CEL predicates. An option predicate fails closed (a wrong one makes its option silently never appear), which runtime fail-open can't surface. Three checks:

    • syntax — invalid CEL, delegated to @objectstack/formula's validateExpression (no schema hint, so a legitimate current_user.roles reference is never flagged);
    • unknown-field — a record.<name> reference to a field the form never declares;
    • option-literal-not-in-domain — a literal compared against an enum sibling that is outside its declared option values, e.g. record.country == 'chna' when country is cn/us (the AI-authoring typo 表单支持级联/依赖选项:新增 SelectOption.visibleWhen 通用谓词 #2284 called out).

    It only flags what it can statically prove — current_user.*, open-domain fields, and unrecognized shapes are left alone, so there are no false positives.

  • Catalog guard (examples/schema-catalog/test/option-predicates.test.tsx): runs the guardrail over every shipped example in CI (pnpm test), and asserts it's non-vacuous against the cascade example.

  • Role-gated demo (examples/schema-catalog/.../role-gated-options.json): a select with a current_user.roles-gated option, wired live into the Select field docs page (content/docs/fields/select.mdx).

  • docs/adr/0058-cascading-select-options.md: the B3 decision record — per-option visibleWhen + dependsOn (over optionsWhen / validFor), the dual-side contract, the client implementation, and the server-enforcement contract.

  • e2e/cascading-options.spec.ts: drives the shipped country → province example on the docs site (no backend) in a real browser, asserting the offered set re-filters live (China → Zhejiang/Guangdong; US → California/Texas) and the stale child value clears. Auto-skips when the docs site isn't served, mirroring docs-smoke.spec.ts.

Verification

  • optionLint unit tests (12) + catalog guardrail over 417 examples + full core evaluator suite (244) — all green.
  • The browser e2e passes 3/3 against a local docs server and skips cleanly when unreachable.
  • Lint + tsc --build clean on the changed packages.

Out of scope (framework-side, still tracked in #1583)

  • Server-side option-value enforcement — reject a submitted value whose option visibleWhen is FALSE, in the @objectstack/objectql rule path (mirroring stripReadonlyWhenFields).
  • Live-backend e2e — a cascading pair on a real showcase object, asserting the server rejects an out-of-set value.

These live in objectstack-ai/framework and need that repo added to the session; happy to follow up there.

Closes part of #1583 (objectui side).

🤖 Generated with Claude Code

https://claude.ai/code/session_01UFBvVjdHzB29XabjYxe1bN


Generated by Claude Code

…wser e2e (#1583)

Complete the objectui side of B3 (dynamic field options / cascading selects):
a build-time guardrail for per-option `visibleWhen` predicates, a role-gated
showcase example, ADR-0058, and a real-browser cascade e2e. The client feature
itself shipped in #2284/#2215 (v12.0.0); this fills the remaining objectui
checklist.

- @object-ui/core: `lintOptionPredicates()` statically validates option
  `visibleWhen` predicates — CEL syntax (via @objectstack/formula
  `validateExpression`), unknown `record.<field>` references, and a literal
  compared against an enum sibling outside its value domain
  (`record.country == 'chna'`, the #2284 AI-typo case). Conservative: only
  flags what it can statically prove; role/context predicates (`current_user.*`)
  and open-domain fields are left alone (no false positives).
- examples/schema-catalog: role-gated select demo (`current_user.roles`), wired
  live into the Select field docs page; a new catalog test runs the guardrail
  over every shipped example.
- e2e/cascading-options.spec.ts: drives the shipped country -> province example
  on the docs site (no backend), asserting the offered set re-filters live and a
  stale child value clears. Auto-skips when the docs site isn't served, like
  docs-smoke.
- docs/adr/0058: the B3 decision record (per-option `visibleWhen` + `dependsOn`
  over `optionsWhen`/`validFor`; dual-side contract; server-enforcement contract).

Server-side option-value enforcement and the live-backend e2e remain
framework-side (tracked in #1583).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UFBvVjdHzB29XabjYxe1bN
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 15, 2026 4:42pm

Request Review

@github-actions github-actions Bot added documentation Improvements or additions to documentation package: core examples tests labels Jul 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.6 KB 350 KB
Entry file index-BtkD4Mh7.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.17KB 2.95KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.12KB 5.00KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 30.17KB 7.28KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 444.40KB 96.05KB
core (index.js) 1.69KB 0.60KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 113.70KB 28.15KB
fields (index.js) 202.59KB 49.53KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.22KB 4.69KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.12KB 12.34KB
plugin-charts (index.js) 46.31KB 13.06KB
plugin-chatbot (index.js) 176.76KB 42.28KB
plugin-dashboard (index.js) 108.35KB 26.87KB
plugin-designer (index.js) 213.94KB 43.03KB
plugin-detail (index.js) 210.47KB 50.99KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 104.26KB 25.24KB
plugin-gantt (index.js) 149.17KB 37.17KB
plugin-grid (index.js) 172.52KB 45.58KB
plugin-kanban (index.js) 48.34KB 13.00KB
plugin-list (index.js) 99.07KB 23.46KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.82KB 9.96KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.54KB 20.82KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 0.79KB 0.43KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang os-zhuang marked this pull request as ready for review July 16, 2026 01:18
@os-zhuang os-zhuang merged commit 0890fa7 into main Jul 16, 2026
10 checks passed
@os-zhuang os-zhuang deleted the claude/dynamic-field-options-cel-ywydwm branch July 16, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation examples package: core tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants