chore(app-shell): remove legacy monolith detail renderer + renderViaSchema kill-switch (ADR-0085 PR4) by os-zhuang · Pull Request #2546 · objectstack-ai/objectui

os-zhuang · 2026-07-15T16:39:23Z

What

Deletes the legacy monolithic DetailView branch inside packages/app-shell/src/views/RecordDetailView.tsx (the non-schema-driven path) together with both of its entry points:

objectDef.detail?.renderViaSchema === false — the last surviving detail.* key (ADR-0085 removed the block from the spec; this key was kept only as this path's kill-switch)
the ?renderViaSchema=0 debug URL param

RecordDetailView now always renders through the SchemaRenderer Page pipeline: an authored PageSchema(pageType='record') when one is assigned, else the buildDefaultPageSchema synthesis.

Why

The dual render path taxed every detail-page feature twice: the fieldGroups wiring (#2149/#2168) had to be implemented in both the monolith and the buildDefaultPageSchema synth, and the two implementations already diverged once (ungrouped-field behavior). Schema-driven has been default-on since Track 3 Phase G, and a two-repo + examples scan found zero authors of renderViaSchema: false.

Changes

RecordDetailView.tsx (~918 lines changed, net −344):
- Removed the renderViaSchemaFlag memo (URL param + objectDef.detail.renderViaSchema reads) and the final legacy <DetailView> return branch.
- Removed the legacy-only eager per-record related-lists fan-out — the schema path's record:related_list renderers self-fetch lazily when their tab is shown, so the preload was pure waste (a record with 8 related lists previously fired ~50 concurrent queries the schema path never read).
- Replaced the intermediate DetailViewSchema (detailSchema) translation layer with a synthParts memo that produces buildDefaultPageSchema's inputs directly (sections, highlightFields, headerActions, related, history). Section derivation and the record-header action list (incl. approval-action injection) are preserved verbatim.
- The DetailView component itself stays in @object-ui/plugin-detail (still used internally by the record:details renderer).
ObjectView.tsx: dropped the now-dead DetailView, RecordChatterPanel import (neither symbol was referenced).
content/docs/guide/slotted-pages.md: replaced the "Disabling the synthesizer entirely" section with a removal note.
Changeset: @object-ui/app-shell patch.

Framework companion (checklist item 3)

Verified in the pinned @objectstack/spec@14.6.0: the renderViaSchema / detail.* typing is already gone from the spec surface (only a source comment noting it "retires together with the legacy monolith render path" remains — cleanup tracked in #2548). No renderer-side or spec-type cleanup is outstanding on this side.

Verification

type-check (app-shell, turbo — 29 tasks) ✅
eslint (both changed files) ✅ 0 errors
build — app-shell ✅ and full console production bundle ✅ (35 tasks, dist produced)
Unit suite ✅ 3012 passed
DOM/UI suite ✅ 2904 passed (24 skipped)
Console browser smoke (Playwright, production bundle) ✅ 10 passed — bootstrap has no critical console errors, client-side routing resolves, SPA fallback serves index.html

Real-backend browser verification → tracked in #2548

Exercising the four detail-page shapes (grouped / ungrouped / stageField:false / related-heavy) against real data needs a running @objectstack backend, which the CI/agent environment doesn't have. Deferred to #2548 (with a repro runbook) rather than blocking this cleanup.

Closes #2181

🤖 Generated with Claude Code

https://claude.ai/code/session_01VRBZFKwqib3pjPUua3LjCP

…chema kill-switch (ADR-0085 PR4) RecordDetailView now always renders through the SchemaRenderer Page pipeline: an authored PageSchema(pageType='record') when assigned, else the buildDefaultPageSchema synthesis. The non-schema-driven monolithic DetailView branch and both entry points are removed: - objectDef.detail?.renderViaSchema === false (the last surviving detail.* key — ADR-0085 removed the block from the spec, keeping this key only as the kill-switch) is no longer read; - the ?renderViaSchema=0 debug URL param is no longer honored. Also drops the legacy-only plumbing this branch required: the eager per-record related-lists fan-out (the schema path's record:related_list self-fetches lazily per tab) and the intermediate DetailViewSchema translation layer, now replaced by a synthParts memo that feeds buildDefaultPageSchema directly. The DetailView component itself stays in @object-ui/plugin-detail (still used by the record:details renderer). Removes the now-dead `DetailView`/`RecordChatterPanel` import in ObjectView and updates the slotted-pages guide. Closes #2181 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRBZFKwqib3pjPUua3LjCP

vercel · 2026-07-15T16:39:30Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 15, 2026 4:39pm

github-actions · 2026-07-15T16:42:32Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.6 KB	350 KB
Entry file	`index-CkaPt_fR.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.17KB	2.95KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.12KB	5.00KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	30.17KB	7.28KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	444.40KB	96.05KB
core (index.js)	1.69KB	0.60KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	113.70KB	28.15KB
fields (index.js)	202.59KB	49.53KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	176.76KB	42.28KB
plugin-dashboard (index.js)	108.35KB	26.87KB
plugin-designer (index.js)	213.94KB	43.03KB
plugin-detail (index.js)	210.47KB	50.99KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.26KB	25.24KB
plugin-gantt (index.js)	149.17KB	37.17KB
plugin-grid (index.js)	172.52KB	45.58KB
plugin-kanban (index.js)	48.34KB	13.00KB
plugin-list (index.js)	99.07KB	23.46KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.82KB	9.96KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.54KB	20.82KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.79KB	0.43KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

os-zhuang mentioned this pull request Jul 16, 2026

Follow-up (ADR-0085 PR4): real-backend browser-verify showcase detail pages + framework renderViaSchema comment cleanup #2548

Open

4 tasks

os-zhuang marked this pull request as ready for review July 16, 2026 01:26

os-zhuang merged commit a56c596 into main Jul 16, 2026
10 checks passed

os-zhuang deleted the claude/remove-legacy-renderer-qctn8c branch July 16, 2026 01:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(app-shell): remove legacy monolith detail renderer + renderViaSchema kill-switch (ADR-0085 PR4)#2546

chore(app-shell): remove legacy monolith detail renderer + renderViaSchema kill-switch (ADR-0085 PR4)#2546
os-zhuang merged 1 commit into
mainfrom
claude/remove-legacy-renderer-qctn8c

os-zhuang commented Jul 15, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Changes

Framework companion (checklist item 3)

Verification

Real-backend browser verification → tracked in #2548

Uh oh!

vercel Bot commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

os-zhuang commented Jul 15, 2026 •

edited

Loading