fix(app-shell): propagate action-param 'visible' through resolveActionParams (finish create-user phone fix) by os-zhuang · Pull Request #2419 · objectstack-ai/objectui

os-zhuang · 2026-07-13T05:14:15Z

The bug

Creating a user still shows a Phone Number field even though the default
backend has no phoneNumber auth plugin — so submitting a phone fails with
Phone numbers require the phoneNumber auth plugin. The prior two-part fix was
supposed to hide it:

objectui feat(core,app-shell): action params honor a 'visible' predicate; hide create-user phone when plugin off #2406 — ActionParamDialog.filterVisibleParams hides a param whose
visible CEL predicate is false.
framework #2871 — serves create_user's phoneNumber param with
visible: 'features.phoneNumber == true'.

Both landed, the backend serves the predicate, features.phoneNumber is
false — yet the field kept rendering.

Root cause

The predicate never reached the dialog. create_user → paramCollectionHandler
→ resolveActionParams → ActionParamDialog. resolveActionParam flattens
each raw spec param into ActionParamDef field-by-field and did not copy
visible (in any of its three return branches). So param.visible was
undefined at the dialog, filterVisibleParams saw no predicate, and the phone
field always rendered. RawActionParam didn't even declare visible.

This is the missing plumbing between #2406 (the filter) and #2871 (the served
predicate).

Fix

RawActionParam gains visible?: string | { dialect?: string; source?: string }.
resolveActionParam propagates visible in all three branches (inline /
field-backed / missing-field), unwrapping the spec's normalized
{ dialect, source } ExpressionInput envelope to a plain CEL string via a
small normaliseVisible helper.

Tests

New resolveActionParams.test.ts (6 cases): raw-string + {dialect,source}
envelope propagation, inline / field-backed / missing-field branches, absent
and empty predicates.
Existing ActionParamDialog.test.tsx (6) still green — 12 passing.
Full type gate: turbo run build --filter=@object-ui/app-shell (29 pkgs) green.

Rollout note

The Setup console is built from a pinned objectui SHA (framework/.objectui-sha
→ scripts/build-console.sh). To reach a running deployment this needs: merge
here → bump framework/.objectui-sha to the new objectui commit → rebuild the
console (scripts/build-console.sh) → restart. A follow-up framework PR will
bump the pin.

Closes the create-user phone issue end to end.

🤖 Generated with Claude Code

…solveActionParams The create-user phone fix (#2406) gated the phoneNumber param with visible: 'features.phoneNumber == true', but resolveActionParam dropped visible when flattening raw spec params into ActionParamDef — so ActionParamDialog's filterVisibleParams never saw the predicate and the phone field kept rendering even with the phoneNumber auth plugin off. Propagate visible in all three resolve branches (inline / field-backed / missing-field), unwrapping the spec's { dialect, source } ExpressionInput envelope to a plain CEL string. Adds RawActionParam.visible + a resolver test. Completes the create-user phone fix end to end. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-07-13T05:14:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 13, 2026 5:14am

github-actions · 2026-07-13T05:18:08Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	60.4 KB	350 KB
Entry file	`index-DbOJwdIy.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.84KB	2.85KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.08KB	4.19KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	14.70KB	4.38KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	28.83KB	7.01KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.74KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	441.51KB	95.26KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	112.33KB	27.89KB
fields (index.js)	190.04KB	46.40KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.41KB	10.65KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	173.88KB	41.49KB
plugin-dashboard (index.js)	108.35KB	26.87KB
plugin-designer (index.js)	213.95KB	43.04KB
plugin-detail (index.js)	210.09KB	50.69KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.27KB	25.25KB
plugin-gantt (index.js)	136.81KB	33.91KB
plugin-grid (index.js)	171.87KB	45.39KB
plugin-kanban (index.js)	48.16KB	12.94KB
plugin-list (index.js)	98.18KB	23.16KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	85.47KB	20.80KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.79KB	0.43KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added the tests label Jul 13, 2026

os-zhuang merged commit 2fb38ed into main Jul 13, 2026
10 checks passed

os-zhuang deleted the fix/resolve-action-params-visible branch July 13, 2026 05:25

os-zhuang mentioned this pull request Jul 13, 2026

chore: bump objectui to 2fb38edbeb12 (finish create-user phone fix — #2419) objectstack-ai/framework#2876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(app-shell): propagate action-param 'visible' through resolveActionParams (finish create-user phone fix)#2419

fix(app-shell): propagate action-param 'visible' through resolveActionParams (finish create-user phone fix)#2419
os-zhuang merged 1 commit into
mainfrom
fix/resolve-action-params-visible

os-zhuang commented Jul 13, 2026

Uh oh!

vercel Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 13, 2026

The bug

Root cause

Fix

Tests

Rollout note

Uh oh!

vercel Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant