fix(app-shell): stop double-firing action error/success toasts in RecordDetailView & delete handler by baozhoutao · Pull Request #2253 · objectstack-ai/objectui

baozhoutao · 2026-07-05T05:10:10Z

问题

Console 记录详情页点一个会失败的 script 动作(如「分配线索」触发后端 RECORD_LOCKED)时,同一条错误 toast 弹两次。后端只抛一次,是纯 UI 重复。排查中一并发现 删除动作 同类重复:失败弹两条、成功也弹两条。

根因

ActionRunner.handlePostExecution 已负责把结果 error 弹成 toast(成功则按 showOnSuccess 弹)。若某 handler 自己又调 toast.* 且 返回 {success:false, error}(成功时未标 silent),而 runner 又设了 onToast,就会被弹第二遍。

RecordDetailView.serverActionHandler(script):失败分支与 catch 分支各自 toast.error 后又返回 error。fix(app-shell): stop double-toasting failed script/modal action errors #2177 只修了孪生副本 useConsoleActionRuntime(interface page),记录详情页这份没修 → 仍双弹。也解释了「两天前修过还在」「同事没 clone objectui 也复现」(都吃同一份已发布的 @objectstack/console)。
useObjectActions.delete(ObjectView 装配 onToast):失败自弹+返回 error → 双弹;成功自弹+未标 silent → runner 追加通用「Action completed successfully」;批量部分失败同理。

改动

RecordDetailView.tsx:两个失败分支去掉自 toast.error,返回 error 交给 runner 弹一次(对齐 fix(app-shell): stop double-toasting failed script/modal action errors #2177)。
useObjectActions.ts:保留更友好的本地化文案(label+description / 批量汇总),失败返回不带 error、成功标 silent:true,避免 runner 重复。

测试

① 单元测试 — 新增 useObjectActions.test.tsx,把 onToast 接到与真实 ObjectView 相同的 sonner sink,断言用户实际所见:

删除失败 → error 恰好 1 次(修前 2 次)
删除成功 → success 恰好 1 次(此条修前报 got 2 times,揪出了成功路径的第 3 处双弹)
批量部分失败 → error 恰好 1 次且带汇总

3 新增 + 83 相关回归(含 #2177 的用例)全绿。

② 产物级证据 — 从本分支构建 console,grep 打包后的 RecordDetailView chunk,对照当初坐实 bug 的同一签名:

bundle	自弹签名 `.error(X),{success:!1,error:X}`
旧发布版 `@objectstack/console@12.1.0`	2 处
本 PR 构建	0 处

发货代码里两处自弹已消失。

vercel · 2026-07-05T05:10:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 5, 2026 5:10am

github-actions · 2026-07-05T05:14:23Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	59.5 KB	350 KB
Entry file	`index-BRAN8zH1.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.51KB	2.72KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.90KB	3.67KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	9.55KB	3.36KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	26.07KB	6.30KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.29KB	0.82KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	436.90KB	93.87KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	109.66KB	27.05KB
fields (index.js)	185.28KB	45.20KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	36.30KB	10.04KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.10KB	12.33KB
plugin-charts (index.js)	46.09KB	12.99KB
plugin-chatbot (index.js)	172.75KB	41.13KB
plugin-dashboard (index.js)	108.28KB	26.86KB
plugin-designer (index.js)	213.48KB	42.95KB
plugin-detail (index.js)	203.08KB	48.92KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	101.47KB	24.65KB
plugin-gantt (index.js)	136.67KB	33.88KB
plugin-grid (index.js)	165.48KB	43.77KB
plugin-kanban (index.js)	48.15KB	12.94KB
plugin-list (index.js)	97.89KB	23.09KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	85.46KB	20.80KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

RecordDetailView's serverActionHandler (script actions) and useObjectActions' delete handler each toasted an error/success themselves AND returned it to the ActionRunner, whose post-execution hook toasts again when onToast is wired — so the same message fired twice (the reported RECORD_LOCKED double-toast, plus a double on delete success/failure). - RecordDetailView: drop the self toast.error in both failure branches; return the error and let the runner surface it once (mirrors #2177's twin fix in useConsoleActionRuntime). - useObjectActions.delete: keep the richer localized toast, return without `error` on failure and mark successful deletes `silent` so the runner doesn't re-toast. - Add useObjectActions.test.tsx asserting a single toast on delete success/failure/partial-bulk-failure.

github-actions Bot added the tests label Jul 5, 2026

os-zhuang merged commit 4fbf910 into main Jul 5, 2026
10 checks passed

os-zhuang deleted the fix/dedupe-recorddetail-delete-toast branch July 5, 2026 06:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(app-shell): stop double-firing action error/success toasts in RecordDetailView & delete handler#2253

fix(app-shell): stop double-firing action error/success toasts in RecordDetailView & delete handler#2253
os-zhuang merged 1 commit into
mainfrom
fix/dedupe-recorddetail-delete-toast

baozhoutao commented Jul 5, 2026

Uh oh!

vercel Bot commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

baozhoutao commented Jul 5, 2026

问题

根因

改动

测试

Uh oh!

vercel Bot commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants