Skip to content

feat(auth): remediation overlay for the ADR-0069 session gate (enforced MFA / password expiry)#2037

Merged
os-zhuang merged 1 commit into
mainfrom
feat/auth-remediation-ui
Jun 27, 2026
Merged

feat(auth): remediation overlay for the ADR-0069 session gate (enforced MFA / password expiry)#2037
os-zhuang merged 1 commit into
mainfrom
feat/auth-remediation-ui

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Adds the Console-side remediation flow for the ADR-0069 authentication session gate. The ObjectStack backend now returns 403 { error: { code: 'MFA_REQUIRED' | 'PASSWORD_EXPIRED' } } from protected endpoints when a logged-in user must enrol an authenticator or change an expired password (framework PRs objectstack-ai/objectstack#2388, #2390). Without this, flipping mfa_required on just shows the user failing requests — this PR makes it usable.

What

  • @object-ui/auth
    • createAuthenticatedFetch detects the gate (403 + recognised code) on every API response and broadcasts it via a tiny module-level emitter (auth-gate-events.ts).
    • AuthProvider exposes remediationRequired + setRemediationRequired and subscribes to the emitter.
    • The twoFactorClient plugin is enabled; enrollTotp(password) / verifyTotp(code) are added to the auth client (mirrors the existing changePassword cast pattern).
  • @object-ui/app-shell
    • RemediationOverlay (mounted in ConsoleShell, above all routes) renders the guided flow:
      • PASSWORD_EXPIRED → change-password form.
      • MFA_REQUIRED → confirm password → QR (rendered client-side via qrcode) + backup codes → verify a 6-digit TOTP.
    • On success it clears the gate and reloads so the app re-fetches cleanly.

Auth, metadata and me/* reads stay reachable (server allow-list), so the overlay renders above a normally-loading shell — it never has to block itself from rendering.

Verification

  • Unit: @object-ui/auth 122 tests pass; @object-ui/auth + @object-ui/app-shell build (tsc) green; lint 0 errors.
  • Browser, end-to-end (Console dev server proxied to a backend with mfa_required on, grace 0):
    1. Un-enrolled user signs in → data calls return 403 MFA_REQUIRED → full-screen overlay appears (auth/meta/me calls stay 200).
    2. Confirm password → /two-factor/enable → real QR + backup codes render.
    3. Enter a real TOTP code → /two-factor/verify-totp → gate clears → reload → the app loads fully (data table renders).

Screenshots of all three steps were captured during verification.

Notes

🤖 Generated with Claude Code

The backend blocks logged-in users from protected resources with
403 { error: { code: MFA_REQUIRED | PASSWORD_EXPIRED } }. The Console now
detects this on every API response and guides the user through the fix instead
of leaving them on failing requests.

- auth: createAuthenticatedFetch detects the gate (403 + code) and broadcasts it
  via a module-level emitter (auth-gate-events); AuthProvider exposes
  remediationRequired + setRemediationRequired and subscribes; the twoFactorClient
  plugin is enabled and enrollTotp/verifyTotp added to the auth client.
- app-shell: RemediationOverlay (mounted in ConsoleShell, above all routes)
  renders the guided flow — expired-password change, or TOTP enrollment
  (password -> QR + backup codes -> verify) — then reloads so the app re-fetches.

Browser-verified end-to-end against a backend with mfa_required: un-enrolled
user's data calls 403 -> overlay -> enroll -> verify a real TOTP -> gate clears
-> app loads. Auth tests 122 pass; auth + app-shell build (tsc) green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jun 27, 2026 5:00pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 59.0 KB 350 KB
Entry file index-ByrDaZZX.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 6.93KB 2.48KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.90KB 3.67KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 9.55KB 3.36KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 26.07KB 6.30KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.29KB 0.82KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 422.37KB 89.87KB
core (index.js) 1.52KB 0.55KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 99.69KB 24.89KB
fields (index.js) 164.60KB 39.84KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.30KB 10.04KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.98KB 12.65KB
plugin-charts (index.js) 45.46KB 12.78KB
plugin-chatbot (index.js) 159.77KB 38.54KB
plugin-dashboard (index.js) 107.36KB 26.65KB
plugin-designer (index.js) 213.42KB 42.94KB
plugin-detail (index.js) 198.30KB 47.91KB
plugin-editor (index.js) 2.38KB 1.06KB
plugin-form (index.js) 93.23KB 22.71KB
plugin-gantt (index.js) 136.68KB 33.88KB
plugin-grid (index.js) 121.64KB 32.95KB
plugin-kanban (index.js) 48.82KB 13.13KB
plugin-list (index.js) 94.53KB 22.32KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 13.58KB 4.64KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.21KB 2.76KB
plugin-view (index.js) 84.45KB 20.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant