Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .changeset/10425-ru-ar-count-labels.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
'@object-ui/i18n': patch
---

Russian now reads correctly at every count on the list view's record-count bar,
and Arabic on that bar, the record picker's count, the activity-feed reaction chip,
the presence avatars' accessible name and overflow tooltip, and the full-page
search count while browsing (objectui#10425).

Each of these surfaces picks its `…One` key at exactly one and the plain key at
every other count. Where the plain key held a single noun form, it was wrong at
some of the counts it serves. The Russian record-count bar read `2 записей` at two
(the language needs `2 записи`) and `21 записей` at twenty-one (it needs
`21 запись`). The Arabic values each held one noun form (the plural for three to
ten, or in `lookup.recordCount` the singular), while Arabic needs different forms
at two, at three to ten and from eleven up.

The count-not-one half of these seven values is now a count label that reads
correctly at any number:

- `ru` `list.recordCount`: `Записей: N`
- `ar` `list.recordCount`: `عدد السجلات: N`
- `ar` `lookup.recordCount`: `عدد السجلات: N`
- `ar` `detail.reactionCount`: the emoji, then `عدد التفاعلات: N`
- `ar` `collaboration.presentUserCount`: `عدد المستخدمين المتواجدين: N`
- `ar` `collaboration.moreUserCount`: `عدد المستخدمين الآخرين: N`
- `ar` `search.itemsAvailable`: `عدد العناصر المتاحة: N`

That is the device objectui#10024 and objectui#10242 used, and the one Russian's
`lookup.recordCount` already uses. The singular halves, the key set, the call sites
and the other eight packs are unchanged.
5 changes: 3 additions & 2 deletions .changeset/9664-search-items-available-plural.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@ its phrasing states no noun to agree with.
One translation changed rather than being added: `ar` wrote both numbers into one
string as a parenthesised marker. Its key can no longer be reached at one item, so
the singular half of that marker was dead weight while the parentheses still
rendered at every count the key does serve. It now uses the same noun pair that
`ar`'s `common.itemCount`/`itemCountOne` already uses.
rendered at every count the key does serve. It now reads as a singular noun at one
item and as a count label at every other count, the shape `ar`'s
`common.itemCount`/`itemCountOne` uses (objectui#10425).
Loading
Loading