fix(tooling): drop the retired /storage mount from the wildcard gate — main is red - #4139
Closed
os-zhuang wants to merge 2 commits into
Closed
fix(tooling): drop the retired /storage mount from the wildcard gate — main is red#4139os-zhuang wants to merge 2 commits into
os-zhuang wants to merge 2 commits into
Conversation
…— main is red #4122 added the wildcard fall-through guard with a MOUNTS ratchet declaring `packages/adapters/hono/src/index.ts:all ${prefix}/storage/*`. #4112 had already retired that mount — the hono adapter now only mentions it in a comment ("This used to be `app.all(prefix + '/storage/*')`"). The two landed in an order that left the declaration pointing at nothing: ✗ wildcard fall-through guard (#4116) packages/adapters/hono/src/index.ts:all `${prefix}/storage/*` DECLARED but not found by the scan. Moved, renamed or deleted? That fails the ESLint job on main, so every open PR inherits a red check it did not cause. Removing the entry is what the guard's own message asks for. Verified: the gate now reports `6 yielding / 1 ratcheted / 5 exempt (12 namespace-claiming mounts)`, and its 15-case self-test still passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #4133, which landed while this was in CI and fixed the same red gate properly. I deleted the stale Verified green on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently red, and every open PR inherits it. Three lines.What happened
#4122 added the wildcard fall-through guard with a
MOUNTSratchet declaring:#4112 ("retire the /storage dispatcher bridge — it never spoke the storage contract") had already removed that mount. What survives at
packages/adapters/hono/src/index.ts:351is a comment about it:// This used to be `app.all(prefix + '/storage/*')` feeding …The two PRs landed in an order that left the declaration pointing at nothing, so the guard fails:
That is the
ESLintjob, which runspnpm check:wildcard-fallthrough. Reproduced on a pristineorigin/mainworktree, and on an unrelated PR branch (#4135, which touches onlypackages/spec/src/ui/**) — this is not caused by any open change.The fix
Remove the entry, which is exactly what the guard's own message asks for. Nothing is being un-ratcheted: the mount it described no longer exists, so there is no fall-through left to classify.
Verification
The script's own 15-case self-test (
--self-test) still passes, and it is the first half of the CI command, so both halves are covered.No changeset — tooling-only, no published package affected.
Refs #4116, #4122, #4112
🤖 Generated with Claude Code