chore(liveness): flip report.order to live now that objectui lowers it (#3916) - #3938
Merged
Merged
Conversation
… it (#3916) `ReportSchema.order` shipped as `planned` + `authorWarn` because only half of it existed: the schema accepted the declaration, `reportSelectionOrder` lowered it and the executor applied it, but objectui's `DatasetReportRenderer` built the selection it posted and never carried `report.order` into it — so an authored ordering reached no query. Marking it `live` then would have been the exact failure the gate exists to catch. objectui#2964 landed the wiring: `useDatasetRows`, the single fetch choke point behind every report path, now carries the lowered ordering across all four call sites (grouped table, embedded chart, matrix cross-tab, each joined block), with the ordering in the refetch signature and narrowed per sub-selection so the chart's x/y query cannot post a key it never selected. The entry therefore flips to `live`, gains the two framework evidence paths (which resolve in this checkout) and a `verifiedAt` stamp, and drops `authorWarn` / `authorHint` — the advisory said the declaration did nothing at runtime, which is no longer true. The separate default this issue also shipped is unchanged and was already live on its own: a selected time dimension sorts ascending server-side, so month and quarter matrix columns are chronological with no `order` declared at all. No behaviour change in this repo; the ledger is the deliverable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CYJ5WSiCgd522s1zCWtmFT
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
size/s
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 105 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3916 的收尾。#3921 的后续，不是它的重开——那个 PR 已经合并，这是一次全新改动。
背景
ReportSchema.order在 #3921 里是以planned+authorWarn上线的，因为当时它只有一半：schema 接受声明、reportSelectionOrder负责降级、executor 会应用排序，但 objectui 的DatasetReportRenderer自己构造它 post 的 selection，从来没把report.order带进去——所以作者写的排序到不了任何查询。当时把它标成
live就正是这个闸门存在的意义所要拦下的那种谎报。现在
objectui#2964 已合并（
85294442），补上了那一半：useDatasetRows作为所有报表路径背后唯一的取数收口，现在把降级后的排序带上了四个调用点——分组表、内嵌图表、matrix 交叉表、每个 joined block——排序进入 refetch signature，并按子选择收窄，以免图表更窄的 x/y 查询 post 一个它没选的键。所以 ledger 条目：
status从planned翻成live；reportSelectionOrder与resolveOrdering/applyOrdering，都能在本 checkout 里解析）和verifiedAt时间戳；authorWarn/authorHint—— 那条 advisory 说的是「你写了这个但运行时什么都不做」，现在不成立了，留着反而误导。note里同时记下了 objectui 侧的落地位置，供下次复核。与时间轴默认排序无关
这次 issue 同时发的另一个东西——选中的时间维度在服务端默认升序——不受影响，它从一开始就独立 live，不需要任何渲染器改动。月/季度的 matrix 列不声明任何
order也是按时间顺序的。验证
pnpm --filter @objectstack/spec check:liveness：（此前是
live 20, planned 1，evidence 156。）本仓无行为变更，ledger 本身就是交付物。
🤖 Generated with Claude Code
https://claude.ai/code/session_01CYJ5WSiCgd522s1zCWtmFT
Generated by Claude Code