docs: withdraw ADR-0107, drop the structured writes proposal (#3700) - #3735
Merged
Conversation
Owner decision: the structured writes declaration will not be built — it duplicates the write set in a second place authors must keep in sync, adding friction and a new error surface, while testing hooks against a SQL driver (in-memory SQLite) already surfaces the failure mode that schemaless memory:// green lights hide. - delete docs/adr/0107-hook-body-write-set-accepted-static-gap.md and its changeset; the author-facing documentation of the gap (hook-bodies.mdx, hooks.mdx best practice, ScriptBodySchema TSDoc) stays — it is the whole disposition - strip now-dangling ADR-0107/#3700 references from hook-bodies.mdx and the TSDoc; reword the mitigation intro that implied a declaration was coming - audit assessment §5 D4: record the revision — (b) dropped, #3700 closed as not planned; (c) unchanged under ADR-0078 §4 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EsRh53G7SMwFQL57BpFDsx
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 28, 2026 01:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner 决策（撤销 #3716 引入的决策记录层）：删除 ADR-0107、关闭 #3700，不开发结构化
writes声明。理由:
writes声明把写入集在第二个地方重复一遍,作者(尤其是 AI 作者)要负责两处同步——增加书写摩擦和新的出错面;而实践中把 hook 放到 SQL driver(内存 SQLite 今天就可用,file::memory:)上真跑一次,就能暴露 schemalessmemory://绿灯掩盖的失败模式。文档标注本身就是全部处置,不需要 ADR + 跟踪 issue 的决策装置。改动内容
docs/adr/0107-hook-body-write-set-accepted-static-gap.md及其空 changeset(adr-0107-hook-body-write-set-accepted-gap.md)。hook-bodies.mdx的 "Not statically checked: the write set" 小节、hooks.mdx最佳实践条目、ScriptBodySchemaTSDoc 均保留,仅剔除指向 ADR-0107 的悬空引用;"Until a structured write declaration exists" 改为 "Because the write set carries no static checking",不再暗示有声明在路上。docs/audits/2026-07-app-metadata-reference-integrity-assessment.md§5 D4 — 追记修订:(b) 放弃、Hook body writes are not statically checkable — accept the gap or giveHookSchemaa structuredwritesdeclaration #3700 以 not planned 关闭;(c) 维持 ADR-0078 §4 原判不变。验证
pnpm --filter @objectstack/spec test:258 个文件、6710 个用例全部通过。pnpm --filter @objectstack/spec check:docs:250 个生成文件与 spec 同步(TSDoc 改动不影响生成 references)。Refs #3700, #3716
🤖 Generated with Claude Code
https://claude.ai/code/session_01EsRh53G7SMwFQL57BpFDsx
Generated by Claude Code