feat(spec)!: delete DEFAULT_DISPATCHER_ROUTES + sweep last graphql fixture debris (#3586) - #3595
Merged
Merged
Conversation
…xture debris (#3586) The const described a route surface that never existed (/workflow, /realtime listed; eight real prefixes missing) and was consumed by nothing in the runtime — only its own tests and api-surface.json. Its one real-world effect was underwriting CLIENT_SPEC_COMPLIANCE.md's false "FULLY COMPLIANT" verdict (retired in #3571). The maintained, guard-enforced source of truth is packages/runtime/src/route-ledger.ts. Since the major train is loading now (#3562, #3581), the removal ships directly instead of the deprecate-first interim step. Also swept what #3562 left behind: registry test fixtures renamed from graphql_api//graphql to honest OData naming, the tautological config.graphql assertions dropped, the stale '"type": "graphql"' JSDoc example corrected. Client's bare tsc -p is verified clean (the TS2741 acceptance item — resolved by #3562's schema change, confirmed here). Closes #3586 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
size/m
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 104 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3586 (#3563 follow-up). Per the release decision, the major train is loading now (#3562 GraphQL surface removal, #3581 ApiMethod enum shrink), so this skips the issue's deprecate-first interim step and ships the removal directly.
What
1.
DEFAULT_DISPATCHER_ROUTESdeleted (packages/spec/src/api/dispatcher.zod.ts)api-surface.json. Re-verified at head: repo-wide and objectui-wide grep show zero consumers./workflowand/realtimelisted (neither dispatcher branch exists), eight real prefixes missing (/keys,/mcp,/mcp/skill,/actions,/security,/share-links,/ready,/openapi.json).CLIENT_SPEC_COMPLIANCE.md's false "FULLY COMPLIANT" verdict (doc retired to a tombstone in feat(client): actions surface — the SDK path to server-registered actions (#3563 PR-2) #3571).packages/runtime/src/route-ledger.ts(feat(runtime): route ledger + conformance guard for the dispatcher↔client surface (#3563) #3569).dispatcher.test.tsremoved with it.2. Last GraphQL fixture debris swept (leftovers from #3562's surface removal)
registry.test.ts: two fixtures still namedgraphql_api/ "GraphQL API" /basePath: '/graphql'(already retyped toodataby feat(spec)!: 移除从未实现的 GraphQL 面 — 不在产品计划 (#2462 后续) #3562) renamed to honest OData naming.query-adapter.test.ts: two tautologicalexpect(config.graphql).toBeUndefined()assertions dropped — the schema no longer has the key, so they asserted that a nonexistent property is undefined.registry.zod.ts: stale"type": "graphql"JSDoc example corrected (the enum member no longer exists).3.
api-surface.jsonregenerated —DEFAULT_DISPATCHER_ROUTES (const)entry dropped (4384 → 4383 exports);check:api-surfacegate passes.Acceptance (from #3586)
Deprecation tags shipped in a minor→ superseded by the ship-now decision; removal lands directly.api-surface.jsonregenerated ✅ (export-surface gate green).tsc -p tsconfig.jsonverified clean ✅ — the TS2741graphqlerror was resolved by feat(spec)!: 移除从未实现的 GraphQL 面 — 不在产品计划 (#2462 后续) #3562'sApiRoutesSchemachange; this PR confirms the acceptance item against a rebuilt spec.Verification
@objectstack/specfull suite: 255 files / 6724 tests pass.@objectstack/runtimeroute-ledger conformance + suite slice: 653 tests pass.packages/clientbaretsc -p tsconfig.json: exit 0.@objectstack/specminor withfeat(spec)!marker, per the launch-window convention (cf. feat(spec)!: 移除从未实现的 GraphQL 面 — 不在产品计划 (#2462 后续) #3562/feat(spec)!: shrink ApiMethod enum to the six primitives (#3543, P2 of #3391) #3581).🤖 Generated with Claude Code
https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
Generated by Claude Code