feat(objectql,metadata-protocol)!: 装配单一来源化 + 删 protocol re-exports — Step 2 PR-C 收官 (#2462) - #3591
Merged
Merged
Conversation
…drop re-exports — ADR-0076 Step 2 PR-C (#2462) - assembleMetadataProtocol() in metadata-protocol is now the ONE assembly (objects + protocol shim + D12 degraded analytics); createMetadataProtocolPlugin (cloud/delegated) and ObjectQLPlugin's registerProtocol convenience mode both mount it (~112 inline lines deleted from the engine plugin; the shim return feeds the engine's mutation-rebind subscription synchronously). - objectql's six protocol re-exports removed (breaking-as-minor per launch-window, #3486/#3488 precedent). Five known importers repointed (rest x3 tests, runtime seed-loader re-export + its integration test); runtime gains the direct metadata-protocol dep. - Recipe correction (recorded on #2462): the objectql→metadata-protocol DEPENDENCY stays — ./core was already protocol-free, and forcing ~20 framework boot sites to mount two plugins is a pure boilerplate tax. Step 2's goal lands as "zero assembly ownership, single source". Verified: full build; objectql 1086, rest 380, runtime 653, dogfood 60/61 in parallel (semantic-roles 10s-hook flake passes solo). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 4 package(s): 30 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 第三腿（收官）+ 一处配方修正
assembleMetadataProtocol()（metadata-protocol）成为唯一装配（对象 + protocol shim + D12 degraded analytics）：createMetadataProtocolPlugin（cloud 委托模式）与ObjectQLPlugin的registerProtocol便利模式挂载同一条代码路径——引擎插件删除 ~112 行内联重复；shim 返回值同步喂给引擎的 mutation-rebind 订阅。ObjectStackProtocolImplementation/SysMetadataRepository/SeedLoaderService/runBuildProbes+ 类型）——直接从@objectstack/metadata-protocolimport（breaking-as-minor 按 launch-window 惯例，feat(spec)!: remove the dead PortalSchema — never-enforced no-op projection (#3464) #3486/feat(spec)!: prune dead ReportColumnSchema/ReportGroupingSchema exports + unread report chart groupBy (#3463) #3488 先例）。已知消费方仅 5 个测试文件已改指；runtime 补直接依赖。cloud 有 1 处测试 import 同款（control-plane-org-scope.integration.test.ts）——下次 SHA bump 时一行修，已在 issue 标注。./core入口本就零 protocol，强迫 framework 内 ~20 个 boot 站点双插件纯属样板税。Step 2 目标落地为"零装配所有权、单一来源"。验证
全仓 build；objectql 1086 / rest 380 / runtime 653 / dogfood 并行 60/61（semantic-roles 10s hook 偶发，单跑过）。
关联 #2462（Step 2 PR-C）。合并后 Step 2 三腿闭环：#3578（A）→ cloud#877（B）→ 本 PR（C）。
🤖 Generated with Claude Code