ci: drop the OS_SANDBOX_HOOK_TIMEOUT_MS=10000 floor — redundant after ADR-0102 D1#3328
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… ADR-0102 D1 #3270 raised the sandbox hook budget workflow-wide to paper over the #3259 load flake: on an oversubscribed runner the fixed per-invocation WASM-creation cost alone tripped the 250ms *wall-clock* hook deadline. ADR-0102 D1 (#3301) changed the budget to *script CPU-time* — VM creation and idle host-await time are no longer charged — so the 250ms default is meaningful again on a loaded runner and this global floor is no longer needed. Removing it also validates the fix end-to-end: the sandbox suite (incl. the nested-write integration tests, which run at the stock default) must stay green at 250ms on CI. Tests that assert a specific budget set it explicitly and are unaffected; production always kept 250ms/5000ms. The env override remains available for constrained hardware. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011iJLjqToxNv1aYP3syQtRp
os-zhuang
force-pushed
the
claude/nested-write-sandbox-timeout-muw13i
branch
from
July 20, 2026 02:34
68a1fbd to
e9342a8
Compare
os-zhuang
marked this pull request as ready for review
July 20, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the ADR-0102 sandbox work (#3275). Removes the workflow-wide
env: OS_SANDBOX_HOOK_TIMEOUT_MS: '10000'added in #3270.Why it's now redundant
#3270 raised the sandbox hook budget across the whole CI workflow to paper over the #3259 flake: on an oversubscribed 4-vCPU runner, the fixed per-invocation WASM-creation cost alone tripped the 250ms wall-clock hook deadline while the VM was still progressing.
ADR-0102 D1 (#3301) changed the budget to script CPU-time: VM creation and idle host-await time are no longer charged. So the 250ms default is meaningful again on a loaded runner, and this global floor is dead weight.
This doubles as an end-to-end validation of D1
With the floor gone, the sandbox suite runs at the stock 250ms CPU budget on CI — including the nested-write integration tests (which were switched to the stock default in Phase 1). If Test Core stays green, that proves the #3259 flake is fixed at the root (VM-creation cost isn't charged to a CPU budget), not merely masked by a larger number.
hookTimeoutMs/ bodytimeoutMs) and are unaffected.OS_SANDBOX_*_TIMEOUT_MS/OS_SANDBOX_WALL_CEILING_MSenv overrides remain available for constrained hardware.Notes
allow-majorto bypass the unrelated pre-existing@objectstack/console: majorchangeset onmain.Please don't fast-merge — the point is to watch Test Core go green at the stock budget first.
🤖 Generated with Claude Code
Generated by Claude Code