Skip to content

test(objectql): guard overlay-only cross-package collision provenance (ADR-0048 #1828) #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 19, 2026
Merged

test(objectql): guard overlay-only cross-package collision provenance (ADR-0048 #1828) #3252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/objectql/src/protocol-meta.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,6 +891,30 @@ describe('ObjectStackProtocolImplementation - Metadata Persistence', () => {
expect(byPkg['com.globex.crm']).toBe('Globex (overlay)');
});

it('keeps both colliding rows when NEITHER package ships an artifact — overlay-only (ADR-0048 #1828)', async () => {
// The case unit tests missed and dogfooding caught: two packages with
// ONLY a sys_metadata overlay each (NO registered artifact — registry
// stays empty for `page`). The list-decorate step grafts each row's
// artifact via getArtifactItem(type, name, <row's own package>); with no
// composite artifact it must NOT fall back to the OTHER package's
// bare-key hydrated overlay, or both rows get stamped with the
// last-hydrated package's `_packageId` (the exact provenance bug the
// getArtifactItem package-scope fix closes).
mockEngine.find.mockResolvedValue([
{ type: 'page', name: 'home', state: 'active', package_id: 'com.acme.crm', metadata: JSON.stringify({ name: 'home', label: 'Acme home' }) },
{ type: 'page', name: 'home', state: 'active', package_id: 'com.globex.crm', metadata: JSON.stringify({ name: 'home', label: 'Globex home' }) },
]);

const result = await protocol.getMetaItems({ type: 'page' });
const homes = (result.items as any[]).filter((i) => i.name === 'home');

expect(homes).toHaveLength(2);
const byPkg = Object.fromEntries(homes.map((h: any) => [h._packageId, h.label]));
// Each row keeps its OWN package — not both stamped with one id.
expect(byPkg['com.acme.crm']).toBe('Acme home');
expect(byPkg['com.globex.crm']).toBe('Globex home');
});

it('single-package env-wide (package-less) overlay still overlays the artifact (ADR-0005 unchanged, #1828)', async () => {
// A package-less overlay (package_id IS NULL) must still WIN over the
// one artifact it customizes and stay a single row — the package-aware
Expand Down