test(showcase): exercise the spec bare-string sort form on a real list view#3174
Merged
Merged
Conversation
…t view
The spec/renderer shape-mismatch audit (objectui#2601) found the showcase
had ZERO list views using @objectstack/spec ListViewSchema.sort's bare
STRING form ('field [asc|desc]') — only the {field,order}[] array form —
which is exactly why the 'schema.sort.map is not a function' crash lurked
undetected. Add sort: 'estimate_hours desc' to the Task List (tabular) view
as a live coverage fixture so the string form is exercised by any browser
dogfood / coverage pass.
Browser-verified end-to-end on latest main (objectui + framework): the list
renders 10 records with no crash, no error boundary, no sort-map error, and
the Estimate column is correctly descending (60→40→30→24→20→18→16→16→12→8).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HG5LQnPbQbjAAyofghzz3Z
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
marked this pull request as ready for review
July 18, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression fixture from the browser verification of the ListView bare-string sort fix (objectstack-ai/objectui#2601).
The spec↔objectui shape-mismatch audit that produced #2601 found the showcase had zero list views using
@objectstack/specListViewSchema.sort's bare string form ("field [asc|desc]") — every view used the{field, order}[]array form. That gap is exactly why the"schema.sort.map is not a function"crash lurked undetected through green unit tests: nothing in the running app exercised the string shape.This adds
sort: 'estimate_hours desc'to the Task List (tabular) view — one line — so the string form is now exercised by any browser dogfood or coverage pass over the showcase.Browser verification (latest main, both repos)
Reproduced end-to-end against a live stack (framework backend + objectui console dev, both on latest
main):GET /api/v1/meta/view/showcase_taskconfirms the server sendssort: "estimate_hours desc"as a plain string (the exact shape that crashed pre-docs(site): mermaid rendering, stat removal, and full-corpus persona-review fixes #2601 objectui);sort.maperror, and the Estimate column is correctly descending: 60 → 40 → 30 → 24 → 20 → 18 → 16 → 16 → 12 → 8. The toolbar Sort control shows "1" active sort.Testing
pnpm testinexamples/app-showcase— 55/55 passing.@objectstack/example-showcaseis private/unpublished.Refs objectstack-ai/objectui#2601, objectstack-ai/objectui#2578
🤖 Generated with Claude Code
https://claude.ai/code/session_01HG5LQnPbQbjAAyofghzz3Z
Generated by Claude Code