fix(showcase): stretch Command Center's flex-column children to full width#2631
Merged
Conversation
…width The 3-up chart band (cc_rowA/cc_rowB) rendered at a collapsed ~100px width per column, wide enough to render but far too narrow to be readable — the "D" chart-width finding from #2616/#2620, not actually fixed by objectui#2254 despite that PR touching this exact area. Root cause: cc_root (the page's outer `type:'flex'` container) never set `alignItems`, so the `flex` component's own default (`align: 'start'` → Tailwind `items-start`) applied. In a `flex-direction:column` container, `align-items:flex-start` means children size to their own content instead of stretching to the container's width — so each grid-based chart band (cc_rowA/cc_rowB) shrank to whatever intrinsic width its charts naturally wanted (~100-130px each) rather than filling the ~1100px available. Verified live (Playwright + a real backend): row-A chart SVGs measured 100px wide before this fix, 350px after — filling the actual available width. Screenshot-confirmed all three charts now render full width with readable axes/legends. The unrelated `coverage.test.ts` failure on this branch (new registry kinds `trigger`/`router`/`function`/`service` not yet in KIND_COVERAGE) pre-exists on main and is untouched by this change.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
marked this pull request as ready for review
July 5, 2026 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the last piece of the "D" (Command Center chart width) finding from #2616/#2620 — confirmed via live browser testing that
objectstack-ai/objectui#2254did not actually fix this despite touching the same styling area (seeobjectstack-ai/objectui#2268).Root cause:
showcase_command_center's outer container (cc_root, atype:'flex'node withresponsiveStylessettingdisplay:'flex', flexDirection:'column') never setalignItems. Theflexcomponent's own default (align:'start'→ Tailwinditems-start) therefore applied. In aflex-direction:columncontainer,align-items:flex-startmeans children size to their own intrinsic content width instead of stretching to fill the container — so each chart band (cc_rowA/cc_rowB, bothdisplay:gridwith 3 equal-width tracks) collapsed to whatever width its charts naturally wanted (~100-130px per column) instead of filling the ~1100px available.One-line fix: add
alignItems: 'stretch'tocc_root'sresponsiveStyles.Verification
Live-tested with Playwright against a real
--fresh --seed-adminbackend + the objectui console dev server (HMR against objectui main + my in-flight fix branch, to isolate this from the console-rebuild pipeline):<svg>bounding boxes measured 100px wide each (getBoundingClientRect(), not eyeballed)Test plan
pnpm build(showcase) — cleanpnpm test(showcase) — 52/53 passing; the 1 failure (coverage.test.ts, new registry kindstrigger/router/function/servicenot yet inKIND_COVERAGE) is confirmed pre-existing onmain(reproduced with this change stashed out) and unrelated to this fixRefs #2616, #2620, objectui#2254, objectui#2268.
Generated by Claude Code