fix(security): surface swallowed permission-set resolution failures (#2565)#2568
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 10 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…2565) resolvePermissionSets swallowed metadata list() and sys_permission_set dbLoader failures silently — fail-closed (unresolvable sets grant nothing), but a transient DB error made custom permission sets vanish with no trace, leaving the resulting 403s undiagnosable. The evaluator now accepts an optional { logger } and emits one warn per failed source, naming the unresolved sets + the error; SecurityPlugin wires its logger into both call sites. Resolution behavior is byte-identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014y5kiH3aPLWtRRRGcVrXcT
os-zhuang
force-pushed
the
claude/2565-permset-resolve-observability
branch
from
July 4, 2026 08:36
0c6f68a to
453476f
Compare
os-zhuang
marked this pull request as ready for review
July 4, 2026 08:47
18 tasks
68 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
修复 #2565(2026-07-04 授权架构评估中发现的可观测性缺口):
PermissionEvaluator.resolvePermissionSets静默吞掉 metadatalist()和sys_permission_setdbLoader 的异常。方向是对的(fail-closed:解析不到的权限集不授予任何权限),但一次瞬时 DB 抖动会让自定义权限集无声消失,由此产生的 403 无从排查。变更
{ logger }参数,两个 catch 各发一条warn,带上未解析的权限集名字 + 错误信息验证
关联
🤖 Generated with Claude Code
https://claude.ai/code/session_014y5kiH3aPLWtRRRGcVrXcT
Generated by Claude Code