feat(auth): surface "SSO Providers" in the Setup nav when SSO is enabled (ADR-0024 / cloud#551)#2389
Merged
Conversation
…led (ADR-0024 / cloud#551) The sys_sso_provider admin object (register/list/delete external OIDC IdPs) had no nav entry — reachable only by direct URL. AuthPlugin now contributes an "SSO Providers" entry into the Setup app's Access Control group, gated on AuthManager.isSsoWired() (captures self-host OS_SSO_ENABLED + cloud per-env planAllowsSso via plugins.sso) so it never renders when the RP is off. Owning-plugin-contributes pattern (ADR-0029 K2), mirrors plugin-security. isSsoWired() made public for the gate. Verified: entry appears under Setup → Access Control when SSO on; the register form renders all fields (incl. discoveryEndpoint/scopes/mapping) and posts to the bridge (200). (The list view shows empty for now — a pre-existing platform behavior shared by all better-auth-managed objects, e.g. OAuth Applications / Identity Links already in nav read 0 via the data API; separate follow-up.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size/s
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 10 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final A5 polish for cloud#551 — adds an 'SSO Providers' entry to Setup → Access Control, gated on AuthManager.isSsoWired() (self-host OS_SSO_ENABLED + cloud per-env planAllowsSso). The register form (form#2386 bridge) renders all fields and posts 200. List view empty is a pre-existing better-auth-managed-object data-API behavior (sys_oauth_application/sys_account already in nav read total:0 too) — separate follow-up. Verified via browser E2E.
🤖 Generated with Claude Code