Skip to content

fix(changeset): the two unreleased /packages-door notes enumerate all three filters that door reads #19616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 1 commit into from
Sep 22, 2026
Merged

fix(changeset): the two unreleased /packages-door notes enumerate all three filters that door reads #19616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/17667-packages-query-contract.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ with the reads, per the maintainer-approved ruling of 2026-09-13 (decision batch
**BREAKING** — `limit` and `cursor` no longer parse on
`ListInstalledPackagesRequestSchema`, and `limit`'s `.default(50)` is gone with
them. Both were declared here and read by nothing: the serving door filters on
`status` / `type` and then returns every remaining row, so no page was ever
withheld and no continuation token was ever minted. The response half's
`status` / `type` / `enabled` and then returns every remaining row, so no page
was ever withheld and no continuation token was ever minted. The response half's
`nextCursor` has never been emitted, so a caller looping "until the cursor runs
out" re-read the first and only page forever, with no error and no `400`.

Expand Down
2 changes: 1 addition & 1 deletion .changeset/scoped-packages-dispatcher-door.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ fix(runtime): mount the scoped `/api/v1/environments/:id/packages*` door, and re

**The wire.** Two responses gained the key their own declared schema requires (contract review of #16628, finding F2). Both additions are **additive** — no key left either payload:

- `GET /packages` now sends **`hasMore`** (`ListInstalledPackagesResponseSchema`). It is `false`: this door applies its `status` / `type` filters and returns every remaining row, reading no `limit` and no `cursor`, so there is no next page to announce.
- `GET /packages` now sends **`hasMore`** (`ListInstalledPackagesResponseSchema`). It is `false`: this door applies its `status` / `type` / `enabled` filters and returns every remaining row, reading no `limit` and no `cursor`, so there is no next page to announce.
- `DELETE /packages/:id` now sends **`packageId`** (`UninstallPackageApiResponseSchema`). `registryRemoved` and `persisted` stay on the wire unchanged.

A client that reads only the keys it read before is unaffected; a client parsing either payload against the published schema stops being refused.
Expand Down
Loading