Repository navigation
docs(scripts): keep the plain-Node manifest reading, drop its dead objectui citation - #18864
Merged
Merged
Conversation
…tation The manifest generator's header cited an objectui issue number for the 2026-08-29 "browser-only is expired" measurement. That number resolves to nothing — 404 on both the issue and the PR endpoint, with seven neighbouring objectui numbers answering 200 on the same endpoint and token — so the zero is the number, not the channel. The claim it supported is true and independently reproduced, so the fact stays and only the citation goes: the paragraph now carries the readings themselves (17 published @object-ui/* 17.6.0 packages, sdui-parser bundled, this generator under plain Node, byte-identical to the tracked artefact) and a number-free tombstone in the form the two sibling gate scripts already carry, so the next author neither follows a dead link nor assumes there was never a reference here. Prose only — no behaviour: regenerating with this header produces the tracked sdui.manifest.json byte for byte. Claude-Session: https://claude.ai/code/session_01JbZnqu8bt6YqfJsr9vaFb3 Co-authored-by: Claude <noreply@anthropic.com>
os-bill
marked this pull request as ready for review
September 18, 2026 02:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18627
Clause-②: no
scripts/gen-sdui-manifest-node.mjswas the last site still citing the dead objectui number for the 2026-08-29 "the browser-only manifest claim is expired" measurement. PR #18608 had already dropped that citation from the two sibling gate scripts and left a number-free tombstone in each; this header was the survivor — and it is the header both corrected sites now send readers to for the readings, so a reader following the corrected trail landed on the one uncorrected number.What changed
Prose only: one docblock paragraph in one dev-only script. No behaviour, no export, no generated artefact.
@object-ui/*17.6.0, 57 configs, 0 lazy stubs, no Playwright, no objectui build.@object-ui/*17.6.0 packages installed from npm,sdui-parserbundled, this generator run under plain Node,sha256 49211fee7792/git hash-object 78f870e42fe9,cmpbyte-identical to the tracked artefact.git grep 'objectui#6741'over the whole tree: 0 hits. The remaining#6741hits are objectstack#6741, the live ADR-governance ruling — a different repository's number, untouched.DARK reading: the generator's behaviour is untouched (must read 0, and does)
Both runs enumerate the same npm install (the second reuses the first via
--modules-root), so the header is the only variable.sha256git hash-objectbe7aeb827549211fee7792cf51…78f870e42fe9fec1…49be1bcc9049211fee7792cf51…78f870e42fe9fec1…sdui.manifest.json49211fee7792cf51…78f870e42fe9fec1…cmppre-edit vs post-edit :: exit 0.cmppost-edit vs tracked :: exit 0.node scripts/check-sdui-manifest.mjs:: exit 0 (artefact, record and pin still agree).The only tracked file either run moved is
scripts/sdui-manifest.record.json, and only itsgeneratedAtstamp (2026-09-08→ the run's own date). It was restored withgit checkout HEAD -- …and the restoration is proven by an emptygit diff HEAD, so this PR does not touch it.Gates
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran …:: 26 derived families, 26 run, 0 NOT-MEASURED, 0 UNRUN — every one recorded ascommand :: exit 0, each exit code captured before any pipe. One run beyond the derived union:node scripts/check-sdui-manifest.mjs.node --stack-size=4000 node_modules/eslint/bin/eslint.js . --no-inline-config --format json:: exit 0 in 68s — 6847 files linted, 0 errors, 0 warnings, this file among them. Taken at49be1bcc90, the final commit.test/typecheckowed here. The file is a repo-root dev script that ships in no package'sfiles[].skip-changeset: nothing published moves — a comment paragraph in a repo-root dev script, in no package tarball.Acceptance notes
#12924, also answers 404 — objectstackissues/12924andpulls/12924both 404, with 10 of the 20 neighbouring numbers 12915–12935 answering 200 on the same endpoint and token, so the zero is that number. ⛔ Deliberately not touched: the card fences this round to the objectui citation. It is also already a known, patrolled case — the H40 row inscripts/pm/check-half-states.mjsrecords#13398 #13399 #13178 #12924 #13456 — HTTP 404 — do not resolveas suppressed cards — and#12924is cited well beyond this file (.github/workflows/lint.yml,.github/workflows/ci.yml,packages/lint/src/sdui-jsx-baseline.json,packages/lint/src/validate-jsx-pages.production-witness.test.ts). Named here for the filing seat; devs do not POST issues.sdui.manifest.jsonand the browser dump differ on the fields the parity gate consumes (18 of 57 components;dataSourcemissing on 15 in the root artefact) — the gate's verdict set is identical under both today, which is the configuration in which the drift is least visible #17735, M1 point at the pin's built tree / M2 retire in favour of the browser dump / M3 keep the skew and add a detector — is untouched and stays open; nothing here anticipates it, because the citation is dead whichever mechanism wins. [finding] the tracked rootsdui.manifest.jsonand the browser dump differ on the fields the parity gate consumes (18 of 57 components;dataSourcemissing on 15 in the root artefact) — the gate's verdict set is identical under both today, which is the configuration in which the drift is least visible #17735 is not addressed by this PR.Generated by Claude Code