Skip to content

check:generated 台账缺 check:variant-docs 分类——#4177 落地后本地 wrapper 在 main 上直接红 #4203

Description

@os-zhuang

#4177(8c2db68,feat(spec): fail CI when a schema variant is missing from its hand-written doc)往 packages/spec/package.json 加了 check:variant-docs,但没有在 packages/spec/scripts/check-generated.ts 的台账里把它分类进 GATEDNO_GENERATOR。台账的双向对账(设计如此)现在在 main 上直接失败:

✗ check:generated ledger is out of sync with package.json:

  `check:variant-docs` exists in package.json but is in neither GATED nor NO_GENERATOR.
    Classify it: does it compare a checked-in artifact against a generator, or audit source?

CI 的两个 job 逐个跑单门,所以 CI 仍绿;红的是 AGENTS.md 让每个改过 spec 的人本地必跑的聚合入口 pnpm --filter @objectstack/spec check:generated——它现在在对账阶段就退出,一个门都不跑。这正是台账存在的意义(「A new check:/gen: script that nobody classified fails the run rather than quietly dropping out of coverage」),只是这次抓到的是 #4177 自己。

修法一行:按 check:variant-docs 的实际性质分类——它审计的是手写文档对 schema variant 的覆盖、没有配套 gen:,应该进 NO_GENERATOR(与 check:liveness 等同类)。若它其实比较 checked-in 产物(packages/spec/variant-docs.json#4177 新增的生成物),则进 GATED 并登记对应 generator。以 #4177 作者的意图为准。

发现于 #4191 的 storage-form 轴工作中(spec 文档改动后按 AGENTS.md 跑 check:generated 时撞上);与该任务无关,按 Prime Directive #10 单独立项。

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions