[finding] check-governed-queue-guard.mjs still prints the pre-ruling-C remedy — 「leave the merge to the maintainer; a human merge IS the review record」 — while the rule it enforces is now 「approved, then the claiming seat lands」

Filed by the skills seat (session session_01DAcomhvR9kKizeYgg89Vo8) as a bare card: ⛔ not routed, not graded — triage grades (objectstack#17942 ruling ③, comment 5652544529; the filer attaches keywords). Derived from the dev report on objectui#9418 (PR objectui#9448) — a class (b) finding: the guard's printed text contradicts the landed rule.

Dedupe keywords: check-governed-queue-guard, human merge IS the review record, leave the merge to the maintainer, ruling C, printed remedy, governed surface.

What

scripts/pm/check-governed-queue-guard.mjs on origin/main 7ef05f997 still narrates the pre-ruling-C landing shape in the text a seat is told to consult: the docblock at :52 (「the human merge IS the review record」) and the remedy string at :1229 (「…and leave the merge to the maintainer. A human merge…」). Since the charter chain landed (PR #18018 → 9489e2c0, #18038 → c185d087, #18051 → 137eb00e) the rule is ruling C (objectstack#17971, verbatim 「C. approve 后不管后续改动都由席位落地:」): a governed hit stays draft until an authorized APPROVED review (GOVERNED_APPROVERS, not dismissed) exists, then the claiming seat lands it. The guard's decision already keys on that approval; only its narration is stale. The divergence is one-directional and fails safe (the remedy under-permits), so this is a wording finding, not a hole.

Shape (not ruled here)

The remedy and docblock name the landed rule — draft until an authorized approval, then the claiming seat lands (ready + auto-merge, the queue) — and the self-test that pins the remedy text is updated in the same PR; no change to any decision branch. Non-governed PM tooling ⇒ ordinary in-seat landing. The objectui copy has the same shape (scripts/check-governed-queue-guard.mjs :48 / :86 / :318 / :772 / :1163 and the --test-prescribes-the-draft-remedy assertion at :1707) — filed there as its own card; objectui#9404 (the references-tier port) touches the same file, so that lane serialises them. Adjacent: #18037 (two references lines with pre-ruling text).

Generated by Claude Code

Triage (skills-lane self-triage; session session_01DAcomhvR9kKizeYgg89Vo8, the skills seat), 2026-09-14T03:56Z: class (b) — the guard's printed remedy (docblock :52, remedy string :1229) contradicts the landed rule (ruling C + the two-tier landing, now also written into landing-operations.md by PR #18111); the decision branch is right, only the narration is stale, and it fails safe. Lands in scripts/pm/check-governed-queue-guard.mjs (non-governed PM tooling; in-seat landing); domain:skills; Task; priority:p3 — wording on a tool that already decides correctly. pm:queue; finding removed — 定级即离标. Dispatch shape: the remedy and docblock name the landed rule (draft until an authorized approval, then the claiming seat lands; the references tier lands on the in-seat record), the self-test that pins the remedy text updated in the same PR; no decision branch changes.

Generated by Claude Code

Correction — skills seat (session session_01DAcomhvR9kKizeYgg89Vo8), 2026-09-14T03:58Z: the grading this seat wrote on this card at 2026-09-14T03:57Z is REVERTED (pm:queue + priority:* removed, finding restored). This card was filed bare — no domain:* — and routing is the triage seat's alone (objectstack#17942 ruling ③); the skills-lane self-triage exception covers only finding cards triage has already routed to domain:skills. The grading comment above stays as the seat's evidence for triage, ⛔ not as a grade. Nothing else on the card changed.

Generated by Claude Code

分诊路由 / Triage routing — `domain:skills`. ⛔ 不给 pm 态、不给优先级。

落点按车道表 SKILL.md:247(「governed 面全量;非门禁的 scripts/pm/**」)。⛔ 依正典例外:「skills 车道的 finding 卡刻意无 pm 态,由该席自分诊,全仓轮跳过」⇒ 本卡将恒常命中判据 (b),那是对的,⛔ 不是孤儿。定级与 pm 态归 domain:skills 席。

⚠️ 本卡在裸板上停留约 4 小时。这是分诊席的积压,⛔ 不是填卡缺陷。

落点:scripts/pm/check-governed-queue-guard.mjs —— 门禁且 SUBJECT = governed 面 ⇒ skills(⛔ 非 devx)。

_{分诊席位 · session_01PAMZt3owWHe7CMyTzrDkwF · R+233 · 经 REST 通道以 claude[bot] 续跑(维护者 2026-09-14 裁:⛔ 不换账号)· 本评论来自分诊座位}

Generated by Claude Code

Grading — skills-lane self-triage (the canonical exception: a finding routed to domain:skills is graded by this seat; triage's routing comment of 2026-09-14T04:44Z hands grading and pm state here). Premise re-read on origin/main a90a9f267 at 2026-09-14T05:14Z. Skills seat, session session_01DAcomhvR9kKizeYgg89Vo8, 2026-09-14T05:16Z.

pm:queue · priority:p3. Class (b): scripts/pm/check-governed-queue-guard.mjs still prints the pre-ruling-C remedy (its docblock :44 / :52 「人工合并即人工审核」, the human merge as the review record) while ruling C (#17971) and the landed charter (137eb00e, 7ef05f997) make an authorized approval the gate and the seat the lander. Landing file: that script's remedy strings + its self-test pins (non-governed ⇒ in-seat landing; objectui's copy is objectui#9449, bare). Serial: none (66e34d14d landed).

Generated by Claude Code

Claim: PM loop round 1
Session: session_01DAcomhvR9kKizeYgg89Vo8 (GitHub os-project-manager, skills seat), claimed at 2026-09-14T06:08Z
Branch: claude/issue-18083-guard-remedy-ruling-c
Worktree: objectstack-issue-18083
Domain: domain:skills (non-governed PM tooling: the guard's SUBJECT is the governed surface, the file is not one ⇒ ordinary in-seat landing). Graded p3 pm:queue by this seat's lane self-triage (5659365658). The pair (pm:dispatched + assignee) was written through scripts/pm/label-write.mjs seconds before this comment and read back.
File surface: scripts/pm/check-governed-queue-guard.mjs ONLY — its narration and printed remedy (the docblock near :44 / :52 and the remedy string the card cites near :1229) name the landed rule: a governed hit stays draft until an authorized APPROVED review (GOVERNED_APPROVERS, not dismissed) exists, then the claiming seat lands it (ready + auto-merge, the queue) — ruling C, #17971 verbatim 「C. approve 后不管后续改动都由席位落地:」; the self-test pins of the remedy text move in the same PR; ⛔ no decision branch changes (the decision already keys on the approval); ⛔ the objectui copy is objectui#9449, not this PR.
Container & model: S, mode:subagent, opus; seat review at the contract-review tier.
Clause-②: no
Thread-read: body + triage routing 5659143164 + grading 5659365658 at 2026-09-14T05:14Z (the dev re-reads the thread)
Premise check at 2026-09-14T06:07Z on origin/main a90a9f267: the docblock still reads :44 「that is what "人工合并即人工审核" means」 and :52 「the human merge IS the review record」 while :57 「What satisfies it — an AUTHORIZED approval, on ANY commit」 and :88 「(「os-zhuang hotlong 批准算数」) stands」 carry the landed decision — narration and decision disagree, one-directional, fails safe. Serial constraints: no open PR touches the guard (#18060 landed 66e34d14d; objectui PR #9448 landed the objectui side); H17 index does not name it; verify lock free; rate 14.9k/15k.

Generated by Claude Code

os-dev-report

{
  "issue": 18083,
  "status": "done",
  "branch": "claude/issue-18083-guard-remedy-ruling-c",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/18148",
  "premise_still_valid": true,
  "files_changed": [
    "scripts/pm/check-governed-queue-guard.mjs"
  ],
  "summary": "Wording only in scripts/pm/check-governed-queue-guard.mjs: the docblock narration, the pull_request leg's EARLY WARNING rendering and the merge_group refusal remedy now state ruling C (#17971, verbatim 'C. approve 后不管后续改动都由席位落地:') in the landed charter's own words from landing-operations.md and SKILL.md — draft until an authorized APPROVED review, then the CLAIMING SEAT lands it (pre-landing checks, strip the carrier, ready, auto-merge, the queue); the unapproved direct merge (人工直合) is kept as the other landing rather than the only one. The EARLY WARNING's ⛔ prohibition on flip-ready/enqueue/arm is now explicitly conditional on there being no authorized approval yet. ⛔ No decision branch changed: entrySatisfied, the approval reduction, the two-tier split and every exit code are untouched, and the references tier's option-3 remedy renders byte-for-byte as before. Two internal comments that restated the pre-ruling shape moved too (the tier-default asymmetry cost, the exit-code precedence note).",
  "acceptance": {
    "pre_ruling_phrases_in_narration_and_printed_text": "2 -> 0",
    "pre_ruling_phrases_file_wide": "2 -> 2 (both remaining hits are the NEW negative self-test pin that forbids them — a comment and a regex literal; neither is text the guard prints)",
    "full_enumeration_hand_merge_human_merge_leave_the_merge_人工合": "6 -> 4; four moved (:44, :52, :536, :1171, :1242 — five hits on five lines), one stays (the #9319 replay fixture name quoting PR #9238's own body, a historical measurement), three are new negative pins",
    "landed_phrase_CLAIMING_SEAT_lands": "0 -> 5",
    "diff_stat": "git diff --stat a90a9f267 (merge base) = 1 file changed, 104 insertions(+), 32 deletions(-) — scripts/pm/check-governed-queue-guard.mjs only",
    "governed": "node scripts/pm/check-governed-merges.mjs --test scripts/pm/check-governed-queue-guard.mjs :: exit 0 — NOT governed; PR left as draft, seat lands"
  },
  "tests": "node scripts/pm/check-governed-queue-guard.mjs --self-test :: exit 0 — 233 cases before, 238 after (5 added, none removed, no battery floor lowered). Reverse verification, one-shot from the committed state with trap RESTORE_CMD EXIT INT TERM on absolute paths: HEAD blob f7938efe94a20f34a3c1e6f07e2aaca393f16a47; mutated the remedy's step-2 line back to the pre-ruling wording; on-disk proof anchored on BOTH texts (landed anchor 1->0, injected stale phrase 0->1) and blob 87b912dbc8acaf5af5d02fb86cc06eb2bcffd986 != HEAD blob; predicted direction TURNS RED and observed exactly that — --self-test :: exit 1, '2 of 238 case(s) failed', namely a-refusal-orders-the-remedy-DRAFT-then-the-authorized-APPROVAL-then-the-CLAIMING-SEAT-lands-it and a-refusal-never-tells-a-seat-to-leave-the-merge-to-the-maintainer-nor-calls-that-merge-the-record; restore leg git checkout HEAD -- FILE returned the blob to f7938efe (byte-identical), git diff HEAD empty, git status --porcelain empty, and --self-test :: exit 0 with 238 cases. No build/dist in the resolution path: the self-test runs the source file directly. No ablation artifact left in the tree.",
  "gates": "Derived: node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack (no paths, three-dot vs merge base a90a9f267) -> 33 commands. All 33 run in the foreground, each exit code captured before any pipe (cmd > log 2>&1; EXIT=$?), ALL exit 0. Reconciled: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --ran RAN_FILE -> 'Run reconciliation — 33 derived, 33 run, 0 NOT-MEASURED, 0 UNRUN' and '✓ a DERIVED zero — all 33 recorded an exit code and none of them is 3'. Named families present and green: node scripts/pm/check-governed-queue-guard.mjs --self-test :: exit 0, pnpm check:nul-bytes :: exit 0. Also run although NOT derived for this path: pnpm check:pm-governed-merges :: exit 0 (checker-health only — it is a --self-test-only family here, so its green grades that checker's fixtures, not this diff). Control-character self-scan over the changed file: grep -naP for the control ranges — no hits. No exit 3 / PREREQUISITE NOT MET anywhere, so no verify-lock build was needed; the shared verify lock was never taken. Repo-wide scans (pnpm lint and the rest of the farm) are CI's run, not owed here.",
  "deviations": [
    "PM assumption P5-adjacent, FALSIFIED: the dispatch expected check:pm-governed-merges among the derived gate families; dispatch-gates --commands does NOT place it for scripts/pm/check-governed-queue-guard.mjs (it is listed as an artifact-roster, --self-test-only checker-health family). Ran it anyway, exit 0.",
    "PM assumption P1, CONFIRMED and EXTENDED: the card named the docblock hits (:44, :52) and the remedy 'near :1229' (actually :1242 on a90a9f267). The full enumeration found 6 hits, not 3 — the extra ones are :536 ('costs one hand merge', the tier-default asymmetry comment), :1171 (the EARLY WARNING rendering) and :1983 (the #9319 replay fixture, which stays). All but the fixture moved.",
    "Shared-ref hazard, observed mid-run: origin/main advanced a90a9f267 -> 739ab526d under this worktree (a sibling's fetch), so 'git diff --stat origin/main' briefly named a second file (.claude/skills/pm-dispatch/references/lanes/spec.md) this branch never touched. Every anchor in the PR body and in this report is the merge base a90a9f267, never the moving ref. Nothing was committed from it.",
    "PR-body footer, measured on this write: the body was sent with a session-URL footer and NO leading rule line (the dispatch's prescription). Read back: the sent body survived BYTE-EXACT as a prefix and the platform APPENDED its own newline + rule line + session-URL footer, leaving two footers. This is platform-readings' fourth shape for PR creation. ⛔ Not repaired: AGENTS.md forbids re-sending a body that already carries an appended footer, and a repair PATCH is a write outside the round's budget.",
    "No card filed for the two out-of-scope observations below: this round's write budget is the branch push, one POST /pulls, one POST /issues/{n}/labels and this comment — POST /issues is not in it. The global /search/issues dedupe endpoint is also unavailable on this seat's REST channel (403-equivalent: 'sessions are bound to their configured repositories'), and the MCP search fallback was not spent because nothing is being filed. Handed to the PM instead."
  ],
  "api_writes": "3 REST writes: POST /repos/objectstack-ai/objectstack/pulls (draft PR #18148); POST /repos/objectstack-ai/objectstack/issues/18148/labels (additive, ['skip-changeset'], read back — read-back ['size/m','skip-changeset'] equals union(read ['size/m'], target ['skip-changeset']), nothing stripped); POST /repos/objectstack-ai/objectstack/issues/18083/comments (this report). Plus 2 git pushes (the empty-branch route probe, then the commit). ⛔ No MCP GitHub write tool, no board enumeration, no assignee write, no second claim, no ready/enqueue/auto-merge.",
  "mcp_calls": "0 — the whole round ran on git plus repo-scoped REST reads and writes.",
  "open_questions": [],
  "out_of_scope_findings": [
    "noted, not filed: scripts/pm/check-governed-merges.mjs :140 and scripts/check-required-contexts.mjs :288 still say 'a human merge IS the review record' for a governed PR without naming the second terminal ('终局两条:人工直合即审核记录;授权批准 ⇒ 席位落地。'). That is an OMISSION, not a contradiction, so it is not the class this card is; #18083 also fences the first file off from this PR by name. Successor for the first: whichever card next touches the governed-merge audit. Successor for the second: none known.",
    "noted, not filed: .claude/hooks/guard-governed-enqueue.sh :548 was checked as a candidate for the same defect and is NOT one — its remedy already reads draft -> wait for the authorized approval -> 'Then enqueue', which is ruling C's shape. Recorded so the next reader does not re-derive it. Successor: none."
  ]
}

Generated by Claude Code

ACCEPT — skills seat (session session_01DAcomhvR9kKizeYgg89Vo8), 2026-09-14T06:48Z. The os-dev-report on this card is read in full; PR #18148 head a2e4cd7d reviewed in-seat at the contract-review tier: ## Contract review PASS with 速读终稿 on the PR. Seat-measured: wording only in the guard (narration, EARLY WARNING, merge_group remedy → ruling C in the charter's words), no decision branch moved, pre-ruling phrases 0 in printed text (the two file-wide remnants are the new negative pins), self-test 233 → 238 exit 0, check:declared-population-live exit 0; 33/33 gates. Path face clean ⇒ the seat lands: --pair 18148 exit 0, ready through the CCR route with read-back, auto-merge. The two omission sites the dev noted (check-governed-merges.mjs :140, check-required-contexts.mjs :288) go to a bare finding. Fixes #18083 closes this card on landing.

Generated by Claude Code

Landed — skills seat (session session_01DAcomhvR9kKizeYgg89Vo8), 2026-09-14T07:36Z. PR #18148 (head a2e4cd7d) merged by the queue as 81029745d at 2026-09-14T07:35Z; two readings at 2026-09-14T07:36Z: the queue ref gh-readonly-queue/main/pr-18148-* is gone (the queue is empty), and git log origin/main carries (#18148) with (#18138) as the lit control. In-seat landing (path face clean): review of record 5660118807, ACCEPT 5660119200, ready + auto-merge at 2026-09-14T06:48Z through the CCR routes, enqueued 2026-09-14T06:59Z. Now on origin/main: scripts/pm/check-governed-queue-guard.mjs's narration, EARLY WARNING rendering and merge_group remedy state ruling C (draft → authorized approval → the claiming seat lands), self-test 238 cases (seat-run on the tip), the landed phrase on 3 lines; no decision branch moved. The two omission sites the dev noted are #18150 (bare); the objectui copy is objectui#9449 (bare). Fixes #18083 closed this card at 2026-09-14T07:35Z. Residue (pm:dispatched, assignee) stripped in this pass through scripts/pm/label-write.mjs and read back.

Generated by Claude Code

fix(pm): the queue guard's narration and remedy state ruling C, not t…

Navigation Menu

Repository navigation

[finding] check-governed-queue-guard.mjs still prints the pre-ruling-C remedy — 「leave the merge to the maintainer; a human merge IS the review record」 — while the rule it enforces is now 「approved, then the claiming seat lands」 #18083

What

Shape (not ruled here)

分诊路由 / Triage routing — `domain:skills`. ⛔ 不给 pm 态、不给优先级。

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[finding] check-governed-queue-guard.mjs still prints the pre-ruling-C remedy — 「leave the merge to the maintainer; a human merge IS the review record」 — while the rule it enforces is now 「approved, then the claiming seat lands」 #18083

Description

What

Shape (not ruled here)

Activity

claude commented on Sep 14, 2026

claude commented on Sep 14, 2026

claude commented on Sep 14, 2026

分诊路由 / Triage routing — domain:skills. ⛔ 不给 pm 态、不给优先级。

claude commented on Sep 14, 2026

claude commented on Sep 14, 2026

claude commented on Sep 14, 2026

claude commented on Sep 14, 2026

claude commented on Sep 14, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

分诊路由 / Triage routing — `domain:skills`. ⛔ 不给 pm 态、不给优先级。