fix(console): bump objectui pin to include sharing/webhook form pickers (#2421)#2881
Merged
Merged
Conversation
feat(fields): pickers for the sharing rule form (object / criteria / recipient) (#2421) objectui@6a741605b1e0c7d8cad94ac4a55cead7801a7e79
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Browser-testing the new "New Sharing Rule" form (
/_console/apps/com.objectstack.setup/sys_sharing_rule?form=new) shows the Object field as a plain free-text input — the admin still has to hand-type the machine name — even though #2878 declaredwidget: 'object-ref'on it. The same is true for the criteria builder (filter-condition) and recipient picker (recipient-picker), and for the webhook form's object field from #2880.Root cause
The picker widgets (
object-ref,filter-condition,recipient-picker) ship in objectui, registered asfield:<widget>components (objectui #2421 /6a741605b1e0). When the widget isn't in the registry, the generic object form resolveswidget || typeand, finding nothing, falls through to the default text<Input>— exactly the "still lets me type it in" behavior.But
.objectui-shapinned the Console SPA ate7bebe929349(objectui #2420) — the commit immediately before the widgets landed. So the prebuilt@objectstack/consolenever contained them. Both #2878 and #2880 assumed "the widget already shipped in objectui," but the pin was never advanced past #2420.Fix
Bump the pinned objectui SHA
e7bebe929349→6a741605b1e0(the immediate next commit, objectui #2421), which registers exactly the three widgets and nothing else. The release pipeline rebuildspackages/consolefrom this SHA, so the shipped Console SPA now resolvesfield:object-ref/field:filter-condition/field:recipient-pickerto real pickers. The widgets read their object catalog fromdataSource.getObjects()and degrade safely to the current value if the catalog can't load.Generated via
scripts/bump-objectui.sh, which also emits the@objectstack/consolechangeset routing the frontend delta through the normal release notes.Changes
.objectui-sha:e7bebe929349→6a741605b1e0.changeset/console-6a741605b1e0.md:@objectstack/consoleminor bump summarizing the objectui range🤖 Generated with Claude Code
Generated by Claude Code