fix: app crash on open non protocol link#96
Open
alekseyFilonenkoDev wants to merge 1 commit intoobipawan:masterfrom
Open
fix: app crash on open non protocol link#96alekseyFilonenkoDev wants to merge 1 commit intoobipawan:masterfrom
alekseyFilonenkoDev wants to merge 1 commit intoobipawan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
TypeError: Cannot read property 'toLowerCase'that occurs when open//example.comlink.Changes
protocol.toLowerCase()and nullish coalescing to empty stringLinking.openURLonLinkErroradded to props for passing error that could happen onLinking.openURLProblem
Pressing on
//example.comlink leads to App crash right now. That’s becausemdurl.parse**returns protocol as null for url like this (even though TS showsUrl.protocol: string).After
TypeErrorfixLinking.openURLfails, so it also should be addressed.Solution
While [//example.com](https://example.com/) invalid for RN, it’s actually valid link for web browsers, so it shouldn’t be prohibited.
So make protocol empty string (which it is for given link), and handle
openURLerror. Also add link error handler, so lib users could get actual error and handle it.Testing