chore: bump k8s dependencies to 1.35.x line - #4
Open
anishbista60 wants to merge 3 commits into
Open
Conversation
Signed-off-by: anish bista <anishbista053@gmail.com>
14 tasks
Signed-off-by: anish bista <anishbista053@gmail.com>
anishbista60
changed the title
There was a problem hiding this comment.
Request changes — Go 1.25 makes go test ./... fail.
Verified
- Direct deps look correct:
k8s.io/{api,apimachinery,client-go} v0.35.6,go 1.25.12. - Binary build (
go build .) succeeds.
Blocker
With Go 1.25, vet runs during go test by default. CI runs exactly:
go test -cover -race -v -mod=readonly ./...
Locally that fails with:
stern/main.go:61:28: non-constant format string in call to fmt.Fprintf
The line is effectively fmt.Fprintf(os.Stdout, str). Please change it to something like fmt.Fprint(os.Stdout, str) (or fmt.Fprintf(os.Stdout, "%s", str)).
Nits
- CI container is
golang:1.25whilego.modpins1.25.12. Prefer aligning the image togolang:1.25.12(or at least documenting why the floating minor is intentional). - I only see a DCO check on the PR, not a completed Actions
CIrun. Please confirm the workflow actually ran (or re-run after the vet fix).
Happy to re-review once the printf/vet fix is in.
Signed-off-by: anish bista <anishbista053@gmail.com>
Author
|
Really appreciated for your help. Just pushed the changes. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as title