TDT-2789 Clarify event visibility default is Google-only#479
Merged
Conversation
The Visibility type hint allowed 'default' for all providers without noting that Microsoft and EWS accounts reject it with a 400 error. Only Google events support 'default'. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AaronDDM
requested changes
Jul 7, 2026
AaronDDM
left a comment
AaronDDM
left a comment
Contributor
There was a problem hiding this comment.
Good afternoon! Thanks for tightening this up — the note is accurate and the provider-specific 400 behaviour is worth calling out. One thing before this ships: there's no entry under the Unreleased section in CHANGELOG.md. Please add a short line under Changed (e.g. "Clarify that event default visibility is Google-only") so the doc fix is tracked. Docs themselves look good.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
AaronDDM
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the docstring for the
Visibilitytype innylas/models/events.pyto note thatdefaultonly works for Google events. Microsoft and EWS accounts return a 400 error whendefaultis sent, but the type hint didn't warn about this.Jira: TDT-2789 (sub-task of TDT-2765)
🤖 Generated with Claude Code