Skip to content

TDT-2790 Clarify event visibility default is Google-only#333

Merged
samLRodrigues merged 2 commits into
mainfrom
fix/event-visibility-google-only
Jul 7, 2026
Merged

TDT-2790 Clarify event visibility default is Google-only#333
samLRodrigues merged 2 commits into
mainfrom
fix/event-visibility-google-only

Conversation

@samLRodrigues

@samLRodrigues samLRodrigues commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What

Updates the KDoc for EventVisibility in src/main/kotlin/com/nylas/models/EventVisibility.kt to note that DEFAULT only works for Google events. Microsoft and EWS accounts return a 400 error when DEFAULT is sent, but the enum docs didn't warn about this.

Jira: TDT-2790 (sub-task of TDT-2765)

🤖 Generated with Claude Code

The EventVisibility KDoc described DEFAULT/PUBLIC/PRIVATE without
noting that Microsoft and EWS accounts reject DEFAULT with a 400
error. Only Google events support DEFAULT.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.73%. Comparing base (559d796) to head (6ffdeea).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #333   +/-   ##
=========================================
  Coverage     83.73%   83.73%           
  Complexity      486      486           
=========================================
  Files            44       44           
  Lines          1359     1359           
  Branches        115      115           
=========================================
  Hits           1138     1138           
  Misses          149      149           
  Partials         72       72           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AaronDDM AaronDDM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good afternoon! Thanks for tightening this up — the note is accurate and the provider-specific 400 behaviour is worth calling out. One thing before this ships: there's no entry under the Unreleased section in CHANGELOG.md. Please add a short line under Changed (e.g. "Clarify that event default visibility is Google-only") so the doc fix is tracked. Docs themselves look good.

@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@samLRodrigues samLRodrigues merged commit 3b233de into main Jul 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants