Permit swap_previous, swap_next to take a list of query strings#892
Open
fionn wants to merge 1 commit into
Open
Permit swap_previous, swap_next to take a list of query strings#892fionn wants to merge 1 commit into
fionn wants to merge 1 commit into
Conversation
The swap_next function takes a query_strings argument. Despite this being plural, the type annotation claims that this should be a string. However, we pass this argument to swap_textobject which expects type string | string[]. This also makes the swap functions better correspond to those of move, e.g. goto_next_start also accepts query_strings of type string[]. The same holds also for swap_previous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
swap_nextfunction takes aquery_stringsargument. Despite this being plural, the type annotation claims that this should be astring. However, we pass this argument toswap_textobjectwhich expects typestring | string[].This also makes the
swapfunctions better correspond to those ofmove, e.g.goto_next_startalso acceptsquery_stringsof typestring[].The same holds also for
swap_previous.