fix(shared): return nil when no parser in find_best_range#886
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
An empty table is truthy in Lua, so callers that guard with 'if range then' did not short-circuit when find_best_range hit the no-parser branch. In move.lua the empty table reached scoring_function and crashed with 'attempt to perform arithmetic on local score (a nil value)' on buffers without a parser. Return nil to match the documented Range6? signature. Fixes nvim-treesitter#883 Signed-off-by: Sai Asish <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty tables are truthy in Lua, so the
if current_range thenguard inmove.luadid not short-circuit whenfind_best_rangehit the no-parser branch. The empty table then reachedscoring_functionand crashed withattempt to perform arithmetic on local 'score' (a nil value)on buffers without a parser (e.g.:e test.txt).Return
nilto match the documentedRange6?signature and bring movement functions in line with the select textobjects no-op behavior.Fixes #883