fix: correctly detect if a path is inside the project root or not#701
Open
jfly wants to merge 1 commit into
Open
fix: correctly detect if a path is inside the project root or not#701jfly wants to merge 1 commit into
jfly wants to merge 1 commit into
Conversation
We had a handful of bugs here:
1. It's not enough to check if a relative path starts with `..`, as it's
valid for files to literally start with 2 dots. You need to check for
the path separator as well.
2. Stdin mode incorrectly assumed that any paths that start with `..`
are outside of the tree root. This is wrong in 2 ways:
- If we're in a subdirectory of the project, `../foo` is still very much inside the
project.
- Path's can still escape without starting with `../`. For example:
`foo/../../bar` escapes the project root.
3. Stdin mode incorrectly treated relative paths given by the user as
relative to the project root. Now they are correctly treated as
relative the current directory, and massaged into paths that are
relative to the project root. The simplest approach to fixing this
was to DRY up the path processing logic between stdin/non stdin mode.
This fixes numtide#700
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a handful of bugs here:
.., as it's valid for files to literally start with 2 dots. You need to check for the path separator as well...are outside of the tree root. This is wrong in 2 ways: - If we're in a subdirectory of the project,../foois still very much inside the project. - Path's can still escape without starting with../. For example:foo/../../barescapes the project root.This fixes #700