build: delete the offline backtest harness - #562
Merged
Conversation
This was referenced Jul 23, 2026
mfw78
added a commit
that referenced
this pull request
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
crates/shepherd-backtest(the offline replay binary) andtools/backtest-collect(the 578-line collector and its 831K committed fixtures dump). Drops the crate from the workspace members and regeneratesCargo.lock; the lock delta is exactly the one removed package entry.Drops
rlibfromethflow-watcher'scrate-type, which existed solely so the harness could drivestrategy::on_chain_logsnatively, leaving the wasmcdylibthe engine actually loads. Thecfg(not(target_arch = "wasm32"))gate in itslib.rsstays, because the crate is still compiled for the host as a workspace member; only the comment that justified it by naming the harness changed.Clears the trailing references: the
clapcomment listing the harness as a consumer, the now-dead fixtures glob in.dockerignore, theDockerfileandorderbook-mockcomments, thenexum-sdk::addressrationale, and thedocs/00-overview.mdcrate tree.Keeps the workspace
hexdependency, whichvidere-testalso uses, and keepsdocs/operations/backtest-reports/backtest-7d-2026-06-22.mdas the historical signed-off record.Why
The watcher indexes from the contract's genesis at startup, so the live path already replays history. A frozen offline corpus re-asserting the same thing adds nothing, and no further backtest runs are planned.
The harness was also not earning its keep as code: it was in neither CI nor the
justfile, had zero tests of its own, and produced exactly one report (window collected 2026-06-22) scoring 240/240 on a fixed corpus. It was nonetheless a workspace member that had to be repaired on every SDK rename, most recently in #470, where its imports still referenced the pre-renamenexum_sdk::status_body.Two
load-testnet-runbook.mdbullets cited "the backtest" as covering appData and order-shape correctness. Rather than leave a dangling pointer, one now points at the genesis replay and the other states plainly that only a live-orderbook run exercises real 4xx variety.Testing
Full local battery green:
cargo fmt --all -- --check,cargo clippy --workspace --all-targets --all-features --locked -D warnings, all 18 guest wasms (17 modules plus the cow adapter),cargo nextest run --workspace --all-features --locked,cargo test --doc,RUSTDOCFLAGS=-D warnings cargo doc --workspace --no-deps --locked,scripts/check-venue-agnostic.sh,scripts/check-cow-orderbook-only.sh.The wasm build is what confirms dropping
rlibis safe:ethflow_watcher.wasmstill builds and the count stays at 18.AI Assistance
Implemented with Claude Code.