Skip to content

docs: park the M1 architecture report + review sweep; drop 0.1-to-0.2 cruft#344

Draft
mfw78 wants to merge 32 commits into
developfrom
docs/m1-design-notes
Draft

docs: park the M1 architecture report + review sweep; drop 0.1-to-0.2 cruft#344
mfw78 wants to merge 32 commits into
developfrom
docs/m1-design-notes

Conversation

@mfw78

@mfw78 mfw78 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

What

Parks two planning artifacts in git so they are durable ahead of the M1 reconciliation, and removes one piece of pre-release cruft:

  • add docs/design/venue-platform-architecture.md — the decision-ready architecture report (target 3-layer arch, capability matrix, reth/alloy DX sketches, R1–R8 red-team, Phase 0–4 migration plan, and the seven platform decisions of 2026-07-14).
  • add docs/design/m1-review-sweep-triage.md — the whole-train review-comment sweep.
  • delete docs/migration/0.1-to-0.2.md — nothing is released, so there is no 0.1 to migrate from.

Why

The design docs existed only as untracked working-tree files. This makes them durable in git without folding them into dev/m1 yet — they inform the reconciliation rather than being part of it. Kept as a draft on a separate branch deliberately.

Testing

Docs only — no build impact.

AI Assistance

Report + sweep authored with Claude; parked here verbatim.

Note: the "Migration from 0.1" prose in docs/08-platform-generalisation.md is also cruft but left for the reconciliation pass (it is a content edit, not a file removal).

mfw78 added 26 commits July 14, 2026 23:18
* feat(sdk): add the keeper conditional-source seam, retry ledger, and run

Introduce the world-neutral half of the poll loop in
nexum_sdk::keeper: a ConditionalSource trait (one watch in, one
outcome out, generic over the host, no venue-transport
pre-abstraction), a Tick carrying the dispatch instant, and the
RetryAction (try-next-block / backoff / drop) whose effects the
Retrier runs through the gate and watch-set stores. RetryAction
moves out of shepherd-sdk; the CoW crate re-exports it so no module
rewires.

shepherd-sdk keeps classify_api_error as the CoW errorType table but
returns the keeper action, and encodes two fixes in the one
classification path: classify_poll_error maps an unrecognised revert
selector with a structured payload to DontTryAgain instead of
re-polling every block forever, and DuplicatedOrder (both spellings)
classifies as already-submitted - the run records the
submitted: receipt and keeps the watch rather than dropping every
future tranche. classify_submit_error widens the table to the whole
CowApiError surface and gives Backoff its producer: a rate-limit
fault with server guidance gates the watch on the epoch clock.

cow::run composes the loop: watch-set scan -> gate check ->
source poll -> PollOutcome dispatch, driving submission through the
existing CowApiHost seam with the journal as the idempotency guard
and the retry ledger as the failure dispatch. Acceptance tests run
against the composed shepherd-sdk-test MockHost as integration
tests; no module is rewired yet.

* docs(sdk): disambiguate the run intra-doc link

* fix(cow): build the classify_poll_error test RpcError data as Bytes

RpcError.data is now Bytes; the test helper takes raw Vec<u8> and wraps
it (Vec -> Bytes is O(1)).

* fix(cow): keep the sweep alive when a post-submit journal write faults

journal.record after a successful submit_order was propagating a store
fault out of submit_ready, aborting the whole watch sweep with the
receipt unwritten - the next tick then re-polled and re-posted the same
order. Log the failure and carry on instead; the already-submitted arm
keeps the re-post idempotent.

Both post-submit writes are covered: the Ok arm and the
already-submitted (DuplicatedOrder) arm.
* feat(sdk): log run diagnostics through the tracing facade

The run logged through the LoggingHost seam, which the
guest tracing capture cannot observe - module tests proving
behaviour identity for keeper ports assert on tracing events.
Route the submit-path diagnostics through the tracing macros with
the wording the legacy twap poll loop established, and give
ConditionalSource a defaulted label so shared log lines attribute
the strategy that produced them.

* refactor(twap-monitor): port the poll loop onto the keeper composition

Reduce strategy.rs to decode and evaluate: log decoding persists
watches through the keeper watch set, and the
getTradeableOrderWithSignature evaluation moves behind
ConditionalSource. The hand-rolled gate keys, watch-update
lifecycle, submitted: markers, and submit-retry dispatch are
deleted in favour of cow::run over the keeper stores and
retry ledger, still on the legacy CowApiHost seam. The MockHost
dispatch tests are untouched - the behaviour-identity proof for
the port.
* feat(sdk-test): namespace the mock local store and share its limits

Rework MockLocalStore to mirror the runtime store's shape: namespaced
views over one shared row map, so identical key strings in sibling
namespaces never collide, plus store-wide entry and byte limits that
span namespaces the way one database file does. Fault injection stays
per-view.

* feat(sdk-test): add the programmable MockVenue on the cow-api seam

Script per-call venue behaviour where MockCowApi replays one response:
a strictly-draining queue of submit outcomes with a configurable
steady-state fallback, per-route response sequences whose final entry
sticks (a terminal order status persists across re-polls), and venue
fault injection that overrides both without consuming them. MockHost
grows a defaulted venue type parameter so the composed host carries
either mock on the same CowApiHost seam. Acceptance tests drive the
keeper run across multi-tick retry, backoff, and outage
scenarios, and module-shaped strategy code against status sequences.
* fix(sdk): drop the watch when the OrderCreation constructor rejects the order

A constructor rejection (zero from, validTo beyond the client-side
one-year horizon) is deterministic for the polled payload: skipping
with the watch intact re-polled and re-warned on every block forever.
Route it through the retry ledger as a drop, matching the pre-keeper
net effect where the orderbook rejected the shipped body (e.g.
ExcessiveValidTo) and the classifier dropped the watch. The
unknown-enum-marker skip keeps its pinned keep-the-watch behaviour.

Also log the keeper-level DontTryAgain removal so a permanent drop is
observable even for sources that do not log their own outcomes.

* fix(stop-loss): record the submitted receipt on a duplicate rejection

classify_api_error maps DuplicatedOrder to TryNextBlock on the
premise that the caller records the submitted: receipt - true for the
run, but stop-loss consumed the classification without the
compensating write, so a duplicate rejection re-POSTed every block
until validTo. Mirror run::submit_ready: treat
already-submitted as success wearing an error status, write the marker
the dedup guard reads, and idle.

* refactor(sdk): hoist the watch key to a free fn and shed the cross-layer dev cycle

WatchSet::key never used the host parameter, forcing a meaningless
turbofish at every call site (one test existed solely to prove two
instantiations agree). keeper::watch_key is the free canon;
WatchSet::key stays as a thin delegate for discoverability.

The keeper acceptance tests only touch the local-store seam, so they
now run against nexum-sdk-test's MockHost (the same MockLocalStore
type), shrinking nexum-sdk's dev cycle from the cross-layer
shepherd-sdk-test pair - which dragged the whole CoW domain layer into
the world-neutral crate's dev graph - to the within-layer pair its own
mock crate documents.

* feat(twap-monitor): carry the revert cause on the permanent poll-drop path

A revert that classifies to DontTryAgain destroyed the watch with only
an Info outcome label; the selector and node message needed to triage
a wrongly-dropped watch were discarded. Warn with both before
returning the outcome, and pin the log lines in the drop test. The
test-only watch_key wrapper now reuses the keeper free fn.

* docs(sdk): correct stale order.rs rustdoc

OrderCreation::from_signed_order_data was renamed to OrderCreation::new
in cowprotocol 0.2; and only the unknown-marker case of order_uid_hex
returning None also stops the submit path downstream - an unsupported
chain id does not, so say so instead of claiming both do.

* chore(backtest): retire the dead app_data resolution scripting

The epic removed resolve_app_data and the orderbook-mock's
GET /api/v1/app_data route, but the replay harness still programmed
that route against a strategy that never requests it. Drop the dead
programming (and the now-unused shepherd-sdk dependency) and refresh
the module doc to the hash-only submission flow. The RejectedExpected
classification is kept for historical report comparability until the
harness is reworked around the observer-only strategy (follow-up).

* docs: surface the keeper and run in the overview; record the cow-rs patch-channel move

The overview's SDK table predated the epic's headline surface: add the
nexum-sdk keeper row and the shepherd-sdk cow::run row. Amend
ADR-0004 with the move of the [patch.crates-io] channel from
bleu/cow-rs to nullislabs/cow-rs and what the pinned rev carries.

* style: rustfmt the sweep additions

* docs: reword PR-number references out of module comments

Numeric issue/PR references in .rs files go stale across repository
moves; describe the change instead of pointing at the review.
* feat(sdk): scaffold nexum-macros and ship #[module] attribute

Add the `nexum-macros` proc-macro crate. `#[nexum_sdk::module]`
generates the per-cdylib glue every module hand-wrote: the
`wit_bindgen::generate!` call for the blanket `shepherd:cow/shepherd`
world, the host adapter via `bind_host_via_wit_bindgen!`, the `Guest`
implementation whose `on-event` dispatches to the named handlers
(`init`, `on_block`, `on_chain_logs`, `on_tick`, `on_message`, with
undefined handlers ignored), and `export!`. The WIT directory is
located by walking up from the consuming crate's manifest, so the
emitted paths need no per-module tuning.

Re-export it as `nexum_sdk::module` and port the example, balance-tracker
and price-alert modules onto it; each strategy MockHost suite passes
unchanged.

* refactor(http-probe): port onto #[nexum::module]

Complete the acceptance list: drop the hand-written wit-bindgen glue,
host adapter, and Guest/export block in favour of the attribute, leaving
only the init and on-block handlers. Strategy MockHost suite unchanged.
Doc 05 was stamped future-direction and described the superseded
macro/TypedState/Signer/HostTransport vision. Replace it with the
shipped module-author persona (nexum-sdk + shepherd-sdk + the landed
#[nexum::module] macro) and the planned venue-adapter persona
(nexum-venue-sdk / per-venue-crate), clearly labelled as design intent
tracked by a separate epic. Drop the deferred-features table and
cross-link ADR-0009 and sdk.md.
* fix(macros): reject typo'd handlers and malformed impls at expansion

A method named on_blocks (or any other on_-prefixed typo) previously
compiled as an ordinary helper while its event silently no-opped; the
only signal was a dead_code warning that vanishes on pub items.
Reserve the on_ prefix for the recognised handler set and error on
anything else.

Also reject trait impls, generic impls, and impls with no recognised
handlers - all previously slipped past the self-type guard and failed
later with incidental, unhygienic errors (or compiled into a do-nothing
module). Document the wit-bindgen direct-dependency and prelude-
shadowing invariants inherited from the generated glue.

* docs(migration): rewrite SDK section 7 around the shipped surface

Section 7 still described the superseded Signer/Messaging/RemoteStore/
provider() vision - APIs that never shipped - and a #[shepherd::module]
macro that does not exist, while doc 05 endorsed it as the authoritative
0.1 -> 0.2 SDK table. Replace it with the real story: 0.1 had no SDK
crate, 0.2 ships nexum-sdk/shepherd-sdk host traits, typed errors, and
the single #[nexum_sdk::module] attribute. Point doc 05's cross-link
text at what the section now says, and fix doc 05 details flagged by
the sweep: the CowApiHost parenthetical (submit_order, cow_api_request),
the crate trees (proptests.rs in both SDK crates), the testing-story
claim (nexum-runtime's feature-gated test_utils::TestRuntime is an
in-tree component-level harness), and the first #[nexum::module]
mention now names the real nexum_sdk path.

* docs(sdk): document the #[nexum_sdk::module] attribute in sdk.md

sdk.md is doc 05's designated day-to-day reference but still presented
the pre-macro bind_host_via_wit_bindgen! flow as the authoring pattern.
Add an authoring section covering the attribute and its handler set,
mention it in the intro, and include nexum-macros in the rustdoc
command.
feat(wit): author the nexum:value-flow types package

Add the egress-neutral value-flow vocabulary at 0.1.0: the settlement
domain (evm-chain or offchain), the asset variant (native-token, erc20,
erc721, erc1155, service, offchain), the service and offchain
descriptors, and the big-endian asset-amount. The package is
dependency-free so it can outlive any interface built on it.

Every identifier is vetted against WIT keywords, in-flight component-model
proposals, and the nine binding-target reserved-word lists, preferring a
two-word kebab id wherever a single word is a keyword anywhere:
native-token over native (a Java modifier), offchain over external (a
Dart keyword), value-flow over value (value-imports is circling that
word). A wasmtime bindgen smoke, compiled under test in the host crate
through a throwaway world, names every generated type and field by its
plain Rust spelling so a keyword collision surfaces as an escaped
identifier and fails the build rather than a downstream binding.
feat(wit): author the nexum:intent package with the pool interface

Add the venue-neutral intent ontology at 0.1.0 over the value-flow
vocabulary: the intent-header (gives/wants/valid-until/settlement/
authorisation), the auth-scheme variant (eip712, eip1271, presign,
offchain-sig, unsigned), the intent-status lifecycle with a structured
fail-reason, the opaque receipt alias, and a self-contained venue-error
(deliberately not embedding the host fault type, so the package's freeze
cadence is not pinned to nexum:host versioning).

The pool interface routes submit/status/cancel by a venue string with
the body as opaque bytes. submit returns a submit-outcome variant from
day one: accepted(receipt), or requires-signing(unsigned-tx) for venues
whose settlement is a host-signed on-chain call. The unsigned-tx record
only describes the call (chain, to, value, input); the host routes it
through the guard's host-signed class and fills gas and fees, so
adapters still structurally cannot move value.

Identifier hygiene follows the value-flow rule (internal-error rather
than internal, a Swift declaration keyword). A wasmtime bindgen smoke,
compiled under test in the host crate through a throwaway world that
imports the pool interface, names every generated type, case, and field
by its plain Rust spelling and pins the three pool function signatures
with a dummy host impl.
* feat(runtime): introduce the venue-adapter component kind

Add the second component kind alongside the event-module. A venue
adapter speaks one venue's protocol over scoped transport only and
exports the intent adapter face.

- WIT: a nexum:intent/adapter interface (derive-header, submit, status,
  cancel) and a nexum:adapter/venue-adapter world that imports scoped
  chain and messaging, exports init plus the adapter face, and withholds
  the core-only primitives.
- Bindings: a second bindgen path binding VenueAdapter beside
  EventModule, reusing the shared nexum:host interfaces via with.
- Manifest: a module-kind discriminator defaulting to event-module, plus
  an adapter capability registry that recognises only the scoped
  transport.
- Engine config: an [[adapters]] table carrying path, manifest, a
  per-adapter HTTP allowlist, and messaging-topic scopes.
- Supervisor: adapters instantiate into supervised stores against a
  dedicated scoped linker, reusing the store, fuel, and restart
  machinery; the kind discriminator gates the load path. No routing yet.
- Messaging: per-store content-topic scope enforced ahead of the
  deferred backend.

* docs(runtime): keep the venue-adapter world token on one line

The bindgen module rustdoc split the `nexum:adapter/venue-adapter` code
span across a line break after the slash, so rustdoc rendered it with a
stray space. Rewrap so the token stays intact.
)

Implement the strategy-facing pool import as a host binding linked into
every module linker, dispatching to a shared router that owns the
installed adapters.

- Bindings: a pool-host bindgen world importing nexum:intent/pool,
  reusing the intent and value-flow types from the venue-adapter
  bindings via `with`, so the outcome and error the router hands back to
  a module are the very types an adapter's submit produced.
- Router: resolve a venue id to its adapter, serialise invocation per
  adapter behind an async mutex (the wasmtime Store is not Sync),
  sequence derive-header, a no-op guard interposition seam, then submit.
  Status and cancel pass through without the header, guard, or quota.
- Quota: a per-caller sliding-window submission budget, with adapter
  decode failures charged to the caller so a module feeding garbage
  bodies exhausts its own budget rather than the adapter's fuel.
- Supervisor: adapters instantiate first and install into the router;
  modules then boot carrying the shared handle, rebuilt identically on
  restart. An init-failed adapter is loaded but not routable.
- Manifest: register nexum:intent/pool as a declarable module capability.
- Config: a [limits.quota] section resolving the per-caller budget.
* feat(sdk): ship nexum-venue-sdk over the venue-adapter world

Introduce the venue-author persona crate: the VenueAdapter trait and
export macro over an in-crate bindgen of the adapter world, the borsh
IntentBody derive whose outer version enum fails unknown tags typedly,
the typed intent client core over the byte-level pool seam, and typed
wrappers over the scoped chain, messaging, and wasi:http imports. The
derive expansion lands in nexum-macros and re-exports from the SDK;
borsh enters the workspace dependency table.

* fix(venue-sdk): wrap the wit chain-error data into Bytes

The SDK RpcError.data is Bytes; the wit-bindgen chain-error carries
Vec<u8>, so wrap it (Vec -> Bytes is O(1)) when reprojecting.
* feat(sdk): capability-select the wit-bindgen host adapter

Split bind_host_via_wit_bindgen! into a types-only base plus one block
per capability, selected through a caps list; the zero-argument form
keeps emitting the full chain, local_store, logging set for modules
compiled against a blanket world. Narrow read_latest_answer to
ChainHost + LoggingHost, the two capabilities it exercises, so modules
whose worlds omit local-store can still call it.

* feat(sdk): emit a per-module world from declared capabilities

Teach #[nexum_sdk::module] to read the crate's module.toml and
synthesize an inline WIT world whose imports are exactly the
[capabilities].required and optional declarations, replacing the
blanket shepherd:cow/shepherd world every module compiled against. The
built component's imports now equal its declarations by construction,
so the runtime's capability check no longer leans on the toolchain
eliding unused imports; an undeclared capability has no bindings at
all, and an unknown capability name is a compile-time error. The
emitted host adapter is capability-selected to match, and a rebuild
anchor on module.toml recompiles the module when the manifest changes.

Narrow price-alert's strategy bound to ChainHost + LoggingHost: its
world imports only its declared chain and logging capabilities, so the
full Host supertrait (which adds local-store) is unimplementable there
by design.

* test(runtime): pin the example component's imports to its declarations

The per-module world acceptance: compile the built example component
and assert its capability-bearing imports resolve to exactly the
manifest's declared set, with no extension interface leaking in. Skips
gracefully when the wasm fixture is not built, like the other e2e
tests.

* docs: record the retirement of import-elision for macro-built modules

Macro-built components import what they declare by construction, so
capability enforcement is a backstop for them; the elision dependency
ADR-0009 flagged now applies only to hand-rolled modules still
compiled against the supertype world.
* feat(runtime): add the intent-status case to the host event variant

The host event variant gains intent-status(intent-status-update): a
venue id, the receipt, and the nexum:intent status vocabulary, so a
subscriber sees where an intent is in its life without knowing how the
host learnt it. nexum:host now depends on nexum:intent, so every
bindgen over the host package carries the intent and value-flow
packages on its resolve path, in dependency order; the runtime
generates the intent types once and the adapter and pool bindgens
remap onto them with 'with'. The module macro recognizes an
on_intent_status handler and the example module ships one.

* feat(runtime): poll venue statuses and fan intent-status events to subscribers

The pool router puts every accepted receipt under watch and, on a
configurable cadence ([limits.status_poll] interval_ms), polls each
adapter's status export, reporting only transitions: the first poll
reports the current status, repeats are deduplicated, a terminal
status prunes the watch, and a receipt the venue disowns is dropped.
A dedicated event-loop stream fans each transition to modules
declaring [[subscription]] kind = "intent-status", optionally
filtered by venue; polling only runs when there is at least one
subscriber and one installed adapter.
Extend nexum-macros with the venue-adapter counterpart to #[module]:
read the crate's module.toml, synthesize a per-component venue-adapter
world exporting init plus nexum:intent/adapter and importing exactly the
declared scoped transport, then emit the per-cdylib wit-bindgen call, the
Guest export glue wiring the adapter's associated functions, and export!.

An adapter built this way imports what its manifest declares and nothing
else, retiring the toolchain-elision dependency on the venue side rather
than as follow-on work. A capability outside the venue-permitted set
(chain, messaging, http) is rejected at expansion, so an adapter
structurally cannot reach host key material or persistent state.

Ship echo-venue as the reference adapter and pin its built component's
capability-bearing imports to its single declared capability.
Venue adapters need a way to prove their wire behaviour against the
venue's published contract, in a form a non-Rust author can consume:
codec vectors and header goldens ship as JSON files (bytes as
lowercase hex) rather than Rust-only test code.

CodecVectors publishes IntentBody wire bytes and holds a codec to
them: round-trip vectors must decode and re-encode byte-exactly, and
the failure vectors pin the typed empty, unknown-version, and
malformed error contract. HeaderGoldens pairs published bodies with
the header a conforming derive-header projects, spelled in serde
mirror types whose case names match the WIT. MockTransport composes
chain, messaging, and outbound HTTP mocks behind the SDK seams,
including the messaging_topics scoping refusal.

A reference venue (schema, derivation, and checked-in fixture files
pinned by regeneration tests) documents both formats and proves the
borsh primitive encodings for authors porting the codec.
feat(examples): pair echo-venue with an echo-client and prove the round-trip

Add echo-client, the strategy half of the echo pair: it submits an
opaque body through nexum:intent/pool on every block and logs the
intent-status transitions the router fans back. Wire both real
components through an integration test that proves the intent core end
to end, module -> host router -> echo adapter submit and status back,
which is the first-train acceptance path.

Settle the echo venue instantly (status now reports settled) so the
round-trip reaches a terminal transition, and hold its header
derivation to the nexum-venue-test kit so echo-venue doubles as the
conformance target alongside its tutorial role.

Register echo-client in the workspace, the build recipes, and CI.
* docs(wit): pin canonical amount encoding and reserve native-token(offchain)

Mandate minimal-length big-endian for asset-amount and require decoders
to compare by value, so the same amount has one canonical wire form
across the binding targets. Document native-token(offchain) as
representable-but-invalid: an off-chain settlement domain has no gas
token, so consumers must reject the pairing rather than interpret it.

* fix(macros): correct venue manifest error attribution and accumulate venue packages

The shared missing-[capabilities] error named #[nexum_sdk::module] even
on the venue path; make it macro-neutral so a venue crate is not told to
use the wrong attribute. Mirror synthesize's package-accumulation loop in
synthesize_venue so a future venue capability carrying an extra WIT
package reaches the resolve path (all venue capabilities are packageless
today, so the base set is unchanged).

* docs: normalise doc comments to British -ise spelling

Align the authorise/authorisation prose in the intent WIT and the
conformance kit with the British spelling used elsewhere and with the
authorisation identifier itself. Doc comments only; no identifier, wire
format, or API name changes.

* docs(runtime): document the pool submit charge asymmetry

State the deliberate rule that a forwarded submission is charged once the
guard admits it regardless of the venue outcome, while a derive-stage
non-decode venue error is left uncharged so the caller may retry.
* feat(cow-venue): scaffold default body slice with borsh IntentBody codec

Stage the CoW venue as a crate of feature slices. The default `body`
slice carries the venue-neutral order and composable intent body types
and the borsh IntentBody codec over the outer per-venue version enum, so
a future adapter component or a strategy module can link the bodies and
codec without the host-side CoW machinery.

The slice links only the venue SDK (for the IntentBody derive) and borsh;
`--no-default-features` drops it to an empty crate. shepherd-sdk gains a
re-export shim under `cow` so the module ports can move off the legacy
path without a breaking rename.

* style(cow-venue): use -ize spelling and drop test reach into borsh __private
* feat(cow-venue): drive cow retry classification from a shipped data table

Ship the CoW orderbook errorType retry policy as data in
crates/cow-venue/data/classification.toml, readable and editable by
non-Rust authors, and add a `client` feature slice that embeds it,
exposes a typed CowClient bound to the CoW venue, and a table-driven
classification API returning the keeper RetryAction.

Replace the hand-coded classify_api_error/is_retriable in the cow error
surface with the table lookup, preserving the already-submitted and
drop-on-unrecognized behaviour. A throttle errorType now maps to
Backoff, so every RetryAction arm is reachable from the table alone,
guarded by a data-vs-code parity test and an untyped-parse test that
proves any TOML reader consumes the same file.

* perf(cow-venue): generate the classification table at build time

shepherd-sdk unconditionally enables the cow-venue client slice, and the
wasm modules (twap-monitor, ethflow-watcher) reach classify_api_error
through shepherd_sdk::cow::run, so the runtime LazyLock TOML
parse linked the full toml/serde/winnow stack into every guest: the
twap-monitor wasm grew ~237 KiB (350 KiB -> 586 KiB).

Move the parse to build.rs. It reads data/classification.toml, validates
the table invariants, and emits a static lookup table; the runtime slice
carries only generated rows and no TOML parser. serde/toml/thiserror
become build- and dev-only. The parse and invariants live in a shared
classification_data module that build.rs and the parity test both link,
so the data-vs-code parity test now re-parses the shipped file and
checks the generated table against it. The guest returns to 351 KiB.
* fix(cow): use canonical InvalidEip1271Signature errorType spelling

The permanent_kinds_yield_drop test asserted on "InvalidErc1271Signature",
which is not a real CoW orderbook errorType (the OpenAPI OrderPostError enum
and cowprotocol's OrderbookApiErrorType both spell it InvalidEip1271Signature,
matching data/classification.toml). The phantom spelling passed only via the
unlisted-default Drop, so it never exercised the real table row. Use the
canonical spelling so the test covers the actual entry.

* docs(cow-venue): ratify deliberate divergence from cowprotocol retry_hint

shepherd-sdk already depends on cowprotocol, whose ApiError::retry_hint()
classifies the same orderbook errorTypes and disagrees with this table on
several (e.g. it retries/backs off InvalidEip1271Signature, InsufficientBalance,
InsufficientAllowance and InvalidAppData where this table drops, and backs off
TooManyLimitOrders for an hour rather than 30s). The table is deliberately not
delegated to it: it is shepherd's own, more conservative policy, kept as data
of record so a non-Rust author owns it and the guest client slice stays free
of the upstream error module. Record that this divergence is intentional so a
future maintainer revisits the policy here rather than swapping the source of
truth. (Also fixes the -ise spelling in the same comment.)

* style(cow-venue): adopt British -ise spelling to match house convention

The crate used American -ize (normalizes/normalization, unrecognized) while
the adjacent domain code (shepherd-sdk cow/order.rs normalised, composable.rs
unrecognised, run.rs) and the repo at large use British -ise. Align
the prose so the sibling modules read consistently.

* fix(cow-venue): allow GenAction variants unused by shipped data

GenAction's variants are constructed only by the build-generated table, so a
classification.toml that carries no row of a given action leaves that variant
unconstructed and trips the -D warnings build. Since which actions appear is a
property of the data, not the code, mark the enum allow(dead_code) so a
data-only edit cannot break the workspace lint gate.
Tip-level residual after the chassis to keeper rename was folded down through the train. Carries the doc-comment prose the fold could not move mechanically (the private-keeper caveat, keeper-run wording) and the current-state design docs brought in line with the Verdict poll seam (PollOutcome to Verdict, decode_revert to LegacyRevertAdapter).
No transaction semantics and no concurrent access (deferred to the
MockRuntime refactor, #94). Salvaged from #168 before closing it as
superseded by the shipped namespaced MockLocalStore.
… triage

The decision-ready architecture report (target 3-layer arch, capability
matrix, reth/alloy DX sketches, R1-R8 red-team, Phase 0-4 migration plan,
and the seven platform decisions of 2026-07-14) and the whole-train
review-comment sweep. Parked on a branch so they are durable in git
ahead of the reconciliation, not yet folded into dev/m1.
Nothing is released, so there is no 0.1 to migrate from; the version
strings are cruft normalizing to a single @0.1.0. The "Migration from
0.1" prose in docs/08 is left for the reconciliation pass.
@mfw78 mfw78 added the base: dev/m1 Open PR targets dev/m1 integration branch — merge AFTER develop PRs; develop merged in last. label Jul 15, 2026
mfw78 added 3 commits July 15, 2026 12:06
…nd issue bodies

The videre reorganisation plan (issue-milestone-plan), the apply script and
per-issue bodies used to file the tracker, and the v1 baseline, kept as the
record of how the milestones and issues were determined.
mfw78 added 3 commits July 16, 2026 12:06
Byte-exact, wasm-tools-validated target for the M1 contract fold (#370): three videre packages, the #360 opaque-status body, the R6 host change, and the rename/normalize map. Records the four locked decisions (thin to the EVM-only surface, big-endian minimal-length amounts, plain-enum status with a standard #360 detail trailer, erc20 without a chain id) and resolves the quote func/record name collision as quote returning a quotation. Notes the supersede in split-plan §7.4.
[venue] section; keeper declares one body_version, adapter declares the body_versions set, install requires membership. nexum-runtime routes [venue] opaquely; the videre-host install predicate enforces. Adapter manifest is the install-time authority, WIT export stays for introspection, macros emit both from one IntentBody so they cannot drift. Decision only; enforcement is M2.
The git-filter-repo + jj + mergiraf recipe and the byte-identical tip oracle, validated by a dry-run of the version-normalize slice. Records the package-scoped-rule hazard (WASI carries its own @0.2.0) and the base-owned-blob finding: a train-range fold cannot normalize nexum:host/shepherd:cow (L1/base packages), so base normalize lands on develop while the train fold handles only the train-owned videre reshape.

@lgahdl lgahdl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low-risk docs park, fine to merge. One thing worth calling out before it does: the PR body deletes docs/migration/0.1-to-0.2.md and acknowledges one leftover cross-reference in docs/08-platform-generalisation.md, but that's not the full list — live references to that path also remain in docs/00-overview.md (lines 20, 312, 381), docs/05-sdk-design.md (296, 436, 608, 961), docs/04-state-store.md:70, and docs/07-rpc-namespace-design.md (110, 1236). All of these will 404 once this merges. Since those files aren't touched by this diff, flagging here rather than as an inline comment — worth a quick follow-up sweep (or folding into the docs/08 cleanup already planned for the reconciliation pass) to either fix the links or explicitly note them as known-broken alongside the acknowledged one.

Everything else checked out clean: the two main parked docs (venue-platform-architecture.md, m1-review-sweep-triage.md) are internally consistent and clearly marked as decision-ready/pre-reconciliation status, and the epic/gap body files I spot-checked read as coherent planning prose.

@lgahdl lgahdl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-posting as an inline comment (my earlier review body-only comment didn't render in the diff view).

@@ -1,536 +0,0 @@
# Migrating from Nexum 0.1 to 0.2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low-risk docs park, fine to merge. One thing worth calling out before this deletion lands: the PR body acknowledges one leftover cross-reference to this file in docs/08-platform-generalisation.md, but that's not the full list — live references to this path also remain in docs/00-overview.md (lines 20, 312, 381), docs/05-sdk-design.md (296, 436, 608, 961), docs/04-state-store.md:70, and docs/07-rpc-namespace-design.md (110, 1236). None of those files are touched by this diff, so I can't anchor inline on them directly — flagging here since this is the file they all point at. All of these will 404 once this merges. Worth a quick follow-up sweep (or folding into the docs/08 cleanup already planned for the reconciliation pass) to either fix the links or explicitly note them as known-broken alongside the acknowledged one.

Base automatically changed from dev/m1 to develop July 27, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base: dev/m1 Open PR targets dev/m1 integration branch — merge AFTER develop PRs; develop merged in last.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants