Conversation
…roduction-grade gate - Add adversarial mandate to reviewer and verify skill: default hypothesis is the code is broken despite green checks - Reorder verification: code review before lint/test, run app first as production-grade gate (output must change when input changes) - Convert all review sections to tables with PASS/FAIL/Fix columns: Correctness, KISS, SOLID, ObjCal, Design Patterns, Tests, Versions/Build - Add UUID Drift bash check: duplicate UUIDs across test functions = REJECTED - Update UUID Uniqueness rule: one function per UUID; if only Given varies it is a property — use Hypothesis @given + @example, not multiple functions - Add production-grade self-check to implementation/SKILL.md: developer must verify output changes with input before handoff - Add design pattern decision table to developer.md (principle #6) - Add PO pre-mortem at scope, ADR review gate, live verification at Step 6 - Add semantic alignment rule and integration test requirement to tdd/SKILL.md - Add architecture contradiction check to implementation/SKILL.md - Add Verification Philosophy section to AGENTS.md - Add docs/academic_research.md: 15 cognitive/social science mechanisms with full citations grounding each workflow design decision - Delete template-report.md (pre-implementation planning doc, now superseded)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@given+@example, not multiple test functions; if When/Then differs useextend-criteriadeveloper.mdandimplementation/SKILL.md; any detected anti-pattern = REJECTEDdocs/academic_research.md— 15 cognitive and social science mechanisms with full citations grounding every design decision in the workflow (pre-mortem, implementation intentions, adversarial collaboration, elaborative encoding, System 2 before System 1, and 10 more)Files Changed
AGENTS.md.opencode/agents/developer.md.opencode/agents/product-owner.md.opencode/agents/reviewer.md.opencode/skills/code-quality/SKILL.md.opencode/skills/extend-criteria/SKILL.md.opencode/skills/implementation/SKILL.md.opencode/skills/scope/SKILL.md.opencode/skills/tdd/SKILL.md.opencode/skills/verify/SKILL.mddocs/academic_research.md