Skip to content

feat(i18n): add Chinese translations#2485

Open
WishMelz wants to merge 1 commit intonpmx-dev:mainfrom
WishMelz:main
Open

feat(i18n): add Chinese translations#2485
WishMelz wants to merge 1 commit intonpmx-dev:mainfrom
WishMelz:main

Conversation

@WishMelz
Copy link
Copy Markdown

📚 Description

update Simplified Chinese and Traditional Chinese translations

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev (canary) Ready Ready Preview, Comment Apr 12, 2026 9:59am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 12, 2026 9:59am
npmx-lunaria Ignored Ignored Apr 12, 2026 9:59am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c7cffa2d-5556-499e-8243-f34024835c5c

📥 Commits

Reviewing files that changed from the base of the PR and between 5cb6bc6 and e9cf2f2.

📒 Files selected for processing (2)
  • i18n/locales/zh-CN.json
  • i18n/locales/zh-TW.json

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added comprehensive Chinese (Simplified and Traditional) localisation for scatter chart comparison view, including chart labels, axis descriptions, freshness score indicators, and copy-to-clipboard text.
    • Introduced name-aware variants for collapse and expand UI controls in Chinese languages, enabling contextual button labels.

Walkthrough

This PR adds internationalization strings for a scatter chart comparison feature and introduces name-aware variants for UI collapse/expand actions in Simplified and Traditional Chinese locale files. Changes include scatter chart labels, axis names, and parameterised collapse/expand text.

Changes

Cohort / File(s) Summary
Chinese locale files
i18n/locales/zh-CN.json, i18n/locales/zh-TW.json
Added scatter chart localizations under compare.scatter_chart with chart title, freshness score, copy-to-clipboard alt-text, filename template, and axis labels. Introduced name-aware variants for collapse/expand UI text: common.collapse_with_name and common.expand_with_name.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
  • whitep4nth3r
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding Chinese translations to i18n locale files (zh-CN and zh-TW).
Description check ✅ Passed The description is directly related to the changeset, clearly stating the update to Simplified and Traditional Chinese translations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @WishMelz! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions
Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/zh-CN.json Localization changed, will be marked as complete.
i18n/locales/zh-TW.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant