fix(arborist): build inventory before calling workspaceNodes#9762
Open
crhallberg wants to merge 1 commit into
Open
fix(arborist): build inventory before calling workspaceNodes#9762crhallberg wants to merge 1 commit into
crhallberg wants to merge 1 commit into
Conversation
Resolves npm#5863: "workspaces <package name> in filter set, but no workspace folder present" warning. When running "npm update", we call Arborist's reify function. Initializing the tree loads the edgesOut and depQueues them, but that queue isn't resolved before we apply user requests. When `applyUserRequests` calls `workspaceNodes`, it is working with an empty inventory. This causes it to throw the warning (see npm#5863) and always return an empty array. SOLUTION: apply user requests after resolving the dependencies queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
When running "npm update", we call Arborist's reify function. Initializing the tree loads the edgesOut and depQueues them, but that queue isn't resolved before we apply user requests. When
applyUserRequestscallsworkspaceNodes, it is working with an dehydrated inventory. This causes it to throw the warning (see #5863) and always return an empty array (no negative effects as far as I can tell).SOLUTION: apply user requests after resolving the dependencies queue.
References
Closes #5863: "workspaces in filter set, but no workspace folder present" warning.