fix(arborist): strip path separators from version in store key#9758
Open
ubeddulla wants to merge 1 commit into
Open
fix(arborist): strip path separators from version in store key#9758ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getKeybuilds the.storekey asname@version-hash;packageNameis already run throughnameFromFolder(per the comment right above it) butversionis interpolated raw.versionispackage.versionstraight from a dependency manifest, and the key becomes a path segment injoin('node_modules', '.store', key, ...), so a git/file/tarball dep with a version like1.0.0/../../../../tmp/xletspath.joincollapse the..and escape the store beforepacote.extractwrites there.Stripped
/and\fromversioningetKey, matching the existingpackageNamehandling. Valid semver has no separators so store keys are unchanged, and the isolated-mode suite stays green.