fix(arborist): run dependency hooks for changed local links#9757
Closed
ychampion wants to merge 1 commit into
Closed
fix(arborist): run dependency hooks for changed local links#9757ychampion wants to merge 1 commit into
ychampion wants to merge 1 commit into
Conversation
Detect dependency-graph changes that do not appear as reify diff children. Constraint: Compare dependency metadata without hashing arbitrary linked package contents. Rejected: Run hooks for every unchanged link | preserves no-op lifecycle behavior. Confidence: high Scope-risk: narrow Directive: Keep link comparison limited to dependency graph fields and pre-reification lock data. Tested: all 59 Arborist test files with 100% coverage; all 112 reify tests; Arborist lint/template checks; changed/no-op CLI smoke; diff checks.
Author
|
I found edge cases in lockfile-free and workspace-filtered installs that make this approach unreliable. I'm withdrawing it rather than asking maintainers to review a partial fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Arborist refreshes a linked target and its lock metadata without producing a root diff child, so the root
dependencieshook was skipped even though the local dependency graph changed.Closes #8984
Validation
../../node_modules/.bin/tap- 59 test files passed with 100% coveragenode . run lint --workspace @npmcli/arborist- passed