chore: add ci check requiring deps: commits for prod dependency changes#9748
Open
reggi wants to merge 1 commit into
Open
chore: add ci check requiring deps: commits for prod dependency changes#9748reggi wants to merge 1 commit into
reggi wants to merge 1 commit into
Conversation
Adds a Pull Request CI check that fails when a production dependency is changed in a first-party manifest (root, workspaces/*, etc.) without a dedicated deps: commit naming that dependency, keeping dependency updates isolated in the git history and changelog. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0adf6d99-eb62-42c3-8bd3-b0d914c465a5
martinrrm
approved these changes
Jul 10, 2026
nishantms
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Adds a new Pull Request CI check that rejects a PR when a production dependency is changed without a dedicated
deps:commit naming that dependency. This keeps dependency updates isolated in the git history and changelog, and prevents prod dep bumps from being buried inside unrelatedfix:/feat:/chore:commits.Motivated by #9740, where a
deps(arborist): validate-npm-package-name ^8.0.0bump was merged inside a singlefix:commit, obscuring why arborist needed a version bump.How it works
scripts/check-deps-commits.js(git + Node builtins only — no dependency install required):package.json,workspaces/*,mock-registry, …) acrossbase...head, excludingnode_modules/**bundle churn.dependenciesentry (ignoresdevDependencies).deps:/deps(scope):/deps!:commit in the branch.deps(arborist): validate-npm-package-name@^8.0.0..github/workflows/deps-commits.ymlruns it on PRs and skips botrelease/v*branches (which bulk-bump interdependencies in onechore: release). Intentionally not template-oss managed.Example (what #9740 would have shown)
Verification
deps: tar@7.5.19(root prod dep bump) → passes ✅mock-registryarborist devDep bump → correctly ignored ✅