fix(diff): strip control chars from generated diff headers#9741
Open
ubeddulla wants to merge 1 commit into
Open
fix(diff): strip control chars from generated diff headers#9741ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatDiff and lib/utils/patch-diff.js build git diff headers by interpolating file paths and manifest versions straight into the diff --git, ---, +++ and index lines. Tarball entry names (read verbatim by untar.js) and non-registry manifest versions are attacker controlled and can hold a newline, so a crafted name or version forges extra header and hunk lines in the output; the global C0/C1 filter lets \n and \r through, so the forgery survives to the terminal and to anything that parses the diff (git apply, or Arborist parsePatch for npm patch). Strip control characters from the name and version before they land in a header line, keeping the original name for refs lookups and disk reads so valid inputs are unchanged.