Add missing test overrides for Contains_on_Enumerable/MemoryExtensions#3821
Open
roji wants to merge 1 commit intohotfix/9.0.5from
Open
Add missing test overrides for Contains_on_Enumerable/MemoryExtensions#3821roji wants to merge 1 commit intohotfix/9.0.5from
roji wants to merge 1 commit intohotfix/9.0.5from
Conversation
EF Core 9.0.14 added Contains_on_Enumerable and Contains_on_MemoryExtensions to PrimitiveCollectionsQueryTestBase. Add the required overrides with SQL assertions to PrimitiveCollectionsQueryNpgsqlTest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds provider-specific overrides for newly introduced EF Core tests in the primitive collections query suite, ensuring Npgsql’s functional tests include the required SQL baselines and CI no longer fails on the “all tests overridden” check.
Changes:
- Add
Contains_on_Enumerableoverride with Npgsql SQL assertion baseline. - Add
Contains_on_MemoryExtensionsoverride with Npgsql SQL assertion baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EF Core 9.0.14 added
Contains_on_EnumerableandContains_on_MemoryExtensionstoPrimitiveCollectionsQueryTestBase(for C# 14 first-class span support). This adds the required overrides with SQL assertions toPrimitiveCollectionsQueryNpgsqlTest, fixing theCheck_all_tests_overriddenfailure on all CI jobs.Fixes the CI failure at https://github.com/npgsql/efcore.pg/actions/runs/24959840704.