fix: skip deduplication for upgrade requests - #5593
Open
Ram-blip wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5593 +/- ##
==========================================
- Coverage 93.47% 93.47% -0.01%
==========================================
Files 110 110
Lines 38238 38238
==========================================
- Hits 35744 35742 -2
- Misses 2494 2496 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
The
deduplicateinterceptor currently treats upgrade-bearing requests as ordinary safe-method requests. SinceDispatcher.upgrade()dispatches aGETwith anupgradeoption, the request can enter the normal response-deduplication path.A successful protocol upgrade completes through
onRequestUpgradeand transfers an upgraded socket instead of following the normalonResponseStart→onResponseData→onResponseEndlifecycle. As a result, the pending deduplication entry is not removed, and later matching requests can attach to stale state without being dispatched or settled.Rationale
Protocol upgrades are stateful operations and cannot share or replay a single upgraded transport across independent callers.
Upgrade-bearing requests should therefore bypass response deduplication before key generation and pending-request lookup. This also prevents collisions between an ordinary
GETand an otherwise identical upgrade-bearingGET.Changes
upgradeis absent or falsey.GET.Features
N/A
Bug Fixes
GETand upgrade-bearingGETrequests from colliding in the deduplication map.Breaking Changes and Deprecations
None.
Status