Skip to content

Add staging subdomain - #998

Open
flakey5 wants to merge 2 commits into
mainfrom
flakey5/20260803/staging
Open

Add staging subdomain#998
flakey5 wants to merge 2 commits into
mainfrom
flakey5/20260803/staging

Conversation

@flakey5

@flakey5 flakey5 commented Aug 4, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
flakey5 requested a review from a team as a code owner August 4, 2026 02:35
@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
New public DNS route for staging increases exposure if mis-deployed, but behavior uses the existing staging env; workers_dev move is config-only.

Overview
Adds a staging route so the dist worker is reachable at r2-staging.nodejs.org/* on the nodejs.org zone, alongside the existing staging env settings (ENVIRONMENT: staging, KV, R2).

Wrangler config cleanup: workers_dev is removed from vars and set as a real Wrangler flag—true on the default/dev and staging envs, false on prod—so it no longer leaks into runtime environment bindings.

worker-configuration.d.ts is refreshed (mostly union-type formatting and a Console.assert signature tweak); no application code changes in the diff.

Reviewed by Cursor Bugbot for commit 7839cb9. Bugbot is set up for automated code reviews on this repo. Configure here.

@ovflowd

ovflowd commented Aug 6, 2026

Copy link
Copy Markdown
Member

@flakey5 updates here?

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants