Repository navigation
tools: add --error-on-warn configure flag in test-shared.yml - #66751
Merged
Merged
Conversation
Member
|
we better wait to have openssl 3.0 and 1.1 back in the matrix (#66711) and passing before proceeding here |
Contributor
Author
|
Blocked on #66752 |
aduh95
added
blocked
Given that this workflow compiles V8 and other libs separately, that would allow us to detect any Node.js-specific warning that needs to be addressed. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
approved these changes
Oct 21, 2026
panva
added
author ready
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
commit-queue
nodejs-github-bot
added
the
lacks-second-approval
Contributor
Author
|
Landed in a232998 |
aduh95
removed
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that this workflow compiles V8 and other libs separately, that would allow us to detect any Node.js-specific warning that needs to be addressed.